From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 463649578 for ; Wed, 25 Nov 2015 19:22:32 +0100 (CET) Received: by wmvv187 with SMTP id v187so269750516wmv.1 for ; Wed, 25 Nov 2015 10:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=MeWVWRL7/jvu1Jgc6jFaDXUhHQ3y+T2FmwqpZ9H1o00=; b=VZD5T1tQRc+H4FHxaKpSHGqm/JhrT+9oGU0FHCd7ZSaG6Av4O1IRv45sLkokZSDM+d w8IWLqOLefeQeKiqHwB1mZRpfB7DlNA0vN5X7bbiThoDeWIc8koFtWD4VnSmm6eqvwiJ BgapvBXmBCs63b9ZHxMDH50m6Rpd/DxqVW2Qnz7raZspAbaA0vAtinjvxAlGEyRPSG/B uV//UQWx61XzhrpPbkTOSErWm/DA46L45sQBXjDyMkcxQ6Kg1I/Rl4xWAhI7R1HzGoYx d3j7KWoKlHcRgT/d5ZQcDthDiE7spFBvvtOrNF9Sz3lupyd6fFrugcRN8lnJTQ8gIKsw mxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=MeWVWRL7/jvu1Jgc6jFaDXUhHQ3y+T2FmwqpZ9H1o00=; b=buZkL7EOQfOO6RSD7ggHepVAApUGJFLCxVWTj+LTIOrGvvTWXe91nMPse2GZFrGQC2 KvdL/NeGP8oyKkPGXod0ugl9UQic11RHmTCAwIQXyYRwtmU7s5O8UNrMbEo7vmIusE2W 9Ekt/j+GOfxvGOJ7DYGEGisCo9M6Umblt6FY4ox63DgP+kJZeThBcN+NATcA9tw5yRZx mspt/EQRhWnAFW5WXWbppAUtYlE280ES56DlJlBdDxcIjt6yNFZTneq0n+Omgw8602Zk UPT9zjdou3xWM25hzCi7qM4XELSbXdKN1uFrikQEOqo8Tm2Zz2ws8zhkAnjK6rnlRnCu XnTA== X-Gm-Message-State: ALoCoQm2o+sRu82+fOHIWVmk3JQqoLGKuxssxXM361X+Mi3e4q5Gmu8+3D7JZppl/W0jX8PN9wZS X-Received: by 10.194.184.104 with SMTP id et8mr41427022wjc.87.1448475752128; Wed, 25 Nov 2015 10:22:32 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id d2sm24301449wjy.16.2015.11.25.10.22.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 Nov 2015 10:22:31 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 25 Nov 2015 19:21:13 +0100 Message-ID: <4113213.2gBx8RUJNc@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1448386677-1441-1-git-send-email-bruce.richardson@intel.com> References: <1447762867-32124-1-git-send-email-bruce.richardson@intel.com> <1448386677-1441-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/2] ethdev: debug code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2015 18:22:32 -0000 2015-11-24 17:37, Bruce Richardson: > This patchset performs two cleanups: > 1. Four functions in ethdev.c which were enabled for debug only have been > merged into their inlined header-file counterparts. This change required that > a number of macros be renamed and moved to the header file too. The macro changes > are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3. > 2. Checks for valid function pointers are added to the API calls for reading > the descriptor ring count, and checking for a valid descriptor. This is because > these functions are not implemented by most drivers, and so it's far safer to > have the check. > > NOTE: This patchset now depends upon the cryptodev patchset Applied with small changes, thanks