From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Raslan Darawsheh" <rasland@nvidia.com>,
matan@nvidia.com, viacheslavo@nvidia.com,
"Benoît Ganne" <bganne@cisco.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update
Date: Fri, 20 Nov 2020 14:50:45 +0100 [thread overview]
Message-ID: <4115497.WuVuNyOrYe@thomas> (raw)
In-Reply-To: <c5b11676-ae1b-2090-1047-849a3a75d59e@intel.com>
20/11/2020 11:51, Ferruh Yigit:
> On 11/19/2020 6:42 PM, Thomas Monjalon wrote:
> > 19/11/2020 18:48, Ferruh Yigit:
> >> On 11/19/2020 2:20 PM, Raslan Darawsheh wrote:
> >>> From: Benoît Ganne <bganne@cisco.com>
> >>>
> >>> mlx5 PMD refuses to update link state if link speed is defined but
> >>> status is down or if link speed is undefined but status is up, even if
> >>> the ioctl() succeeded.
> >>> This prevents application to detect link up/down event, especially when
> >>> the link speed is not correctly detected.
> >>> As link speed is nice to have whereas link status is mandatory for
> >>> operations, always update link state regardless of link speed. The
> >>> application can then check link speed if needs be.
> >>>
> >>
> >> Hi Raslan, Matan,
> >>
> >> Can you please provide the Fixes tag? Also should this fix backported?
> >
> > I think it should not be backported because it is a behaviour change
> > relying on API doc change.
> >
>
> As far as I understand, API change you mention is making 'ETH_SPEED_NUM_UNKNOWN'
> speed value a valid value return value.
>
> Commit log doesn't give the context that it relies on an ethdev behavior change,
> it sounds like it is fixing behavior in the driver, it is not possible to figure
> out the relation without digging the mail list discussions.
> It would be nice to update the commit log to give more details, I think problem
> is clear but can good to add why the check was there at first place and why it
> can be removed now, etc..
Yes I can help improving the explanations.
> Btw with LTS, with the faulty kernel driver, PMD still won't able to get link
> speed which will prevent returning link status.
With this PMD change, the link status is returned even if link speed
is not available.
> Or is the kernel driver fixed and no need to worry about this anymore?
Yes the kernel driver is fixed since a long time.
next prev parent reply other threads:[~2020-11-20 13:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 17:24 [dpdk-dev] [PATCH] " Benoît Ganne
2020-03-29 7:00 ` Matan Azrad
2020-03-30 9:55 ` Benoit Ganne (bganne)
2020-03-30 10:12 ` Matan Azrad
2020-03-30 12:03 ` Benoit Ganne (bganne)
2020-03-30 13:44 ` Matan Azrad
2020-03-30 13:53 ` Benoit Ganne (bganne)
2020-03-30 16:13 ` Matan Azrad
2020-04-01 10:17 ` Benoit Ganne (bganne)
2020-04-01 12:46 ` Matan Azrad
2020-04-07 12:54 ` Thomas Monjalon
2020-04-07 13:41 ` Benoit Ganne (bganne)
2020-11-19 8:30 ` Matan Azrad
2020-11-19 14:20 ` [dpdk-dev] [PATCH v2] " Raslan Darawsheh
2020-11-19 16:27 ` Raslan Darawsheh
2020-11-19 17:48 ` Ferruh Yigit
2020-11-19 18:42 ` Thomas Monjalon
2020-11-20 10:51 ` Ferruh Yigit
2020-11-20 13:50 ` Thomas Monjalon [this message]
2020-11-20 14:21 ` Ferruh Yigit
2020-11-22 10:03 ` Raslan Darawsheh
2020-11-22 10:04 ` [dpdk-dev] [PATCH v3] net/mlx5: allow unknown link speed Raslan Darawsheh
2020-11-22 12:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4115497.WuVuNyOrYe@thomas \
--to=thomas@monjalon.net \
--cc=bganne@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).