From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B1A3A04DD; Fri, 20 Nov 2020 14:50:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6F1EF90; Fri, 20 Nov 2020 14:50:53 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9F2883B5 for ; Fri, 20 Nov 2020 14:50:51 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 27C035C013E; Fri, 20 Nov 2020 08:50:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 20 Nov 2020 08:50:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= PC9TPiZ60A0LCDFgOjmIYsGCsTJMj902tff0NnVKSYc=; b=s0XiiNPd/QYX8CWj niNYKPRKE+bV4CwCNnY7vKOWOReUgVD2KCGVQ3JGMKGPGCRvI4ZhTsKdlAzEzrej jxqHc7BvoYsXrK3Ca6FBGX1jdONFHtvnBdeppIsLXsgVHaoQ+xR8gzz46PSEAajf ui80q3vXrxvqFMw35uynMnOlNpAEEOnKKkhK3L4yK8L5J/Qu8wPkqLOP7OwoCuet aYg1tgooFjs6W/7FXdgICFUjDZaxN59OTnesAyQnllFieP6M5m/bZq9n00BwrrbN MGL/3ahTwjwFFAKjCx5GF07D35vmbdrsjUt6dtJiWaHr8DG9PbvPMXNqxQl/fNlU U+Zu5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PC9TPiZ60A0LCDFgOjmIYsGCsTJMj902tff0NnVKS Yc=; b=T5EC6MDpJmZhpTnmSauTunjnWuUrKyjM2TnvPdeCZs1czpNXdxrV64E5h u8i5+u1anBOJIcaj9tgIt/yRcd/sGn7vqnsPIin/BBuZnIilRrtAjjclcf7TcNqS Zk3oqT1akNFMULvBpz5kjHwvXJDLMCXTDnzvISIUJS+U4LgGGXlJIUv2wwM4MiqV R/4K0gm5API2RQtxkYiTmNQT+A4ixi7j9T8dO6CR+LyUHXoVElTxP4uRTNu1HojL J264QoMx3fsHMZNwNYF1iPdGubcH5yAjY324IAnoNAuCRnxdsZMZg2CAviYhJN8u uIy8GWaArxa0XL9mMU3vYxH98FZkA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegtddgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5ADB3280065; Fri, 20 Nov 2020 08:50:46 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Raslan Darawsheh , matan@nvidia.com, viacheslavo@nvidia.com, =?ISO-8859-1?Q?Beno=EEt?= Ganne , dev@dpdk.org Date: Fri, 20 Nov 2020 14:50:45 +0100 Message-ID: <4115497.WuVuNyOrYe@thomas> In-Reply-To: References: <20200327172449.6514-1-bganne@cisco.com> <6072180.DC7U9P3PlK@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/11/2020 11:51, Ferruh Yigit: > On 11/19/2020 6:42 PM, Thomas Monjalon wrote: > > 19/11/2020 18:48, Ferruh Yigit: > >> On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: > >>> From: Beno=EEt Ganne > >>> > >>> mlx5 PMD refuses to update link state if link speed is defined but > >>> status is down or if link speed is undefined but status is up, even if > >>> the ioctl() succeeded. > >>> This prevents application to detect link up/down event, especially wh= en > >>> the link speed is not correctly detected. > >>> As link speed is nice to have whereas link status is mandatory for > >>> operations, always update link state regardless of link speed. The > >>> application can then check link speed if needs be. > >>> > >> > >> Hi Raslan, Matan, > >> > >> Can you please provide the Fixes tag? Also should this fix backported? > >=20 > > I think it should not be backported because it is a behaviour change > > relying on API doc change. > >=20 >=20 > As far as I understand, API change you mention is making 'ETH_SPEED_NUM_U= NKNOWN'=20 > speed value a valid value return value. >=20 > Commit log doesn't give the context that it relies on an ethdev behavior = change, > it sounds like it is fixing behavior in the driver, it is not possible to= figure=20 > out the relation without digging the mail list discussions. > It would be nice to update the commit log to give more details, I think p= roblem=20 > is clear but can good to add why the check was there at first place and w= hy it=20 > can be removed now, etc.. Yes I can help improving the explanations. > Btw with LTS, with the faulty kernel driver, PMD still won't able to get = link=20 > speed which will prevent returning link status. With this PMD change, the link status is returned even if link speed is not available. > Or is the kernel driver fixed and no need to worry about this anymore? Yes the kernel driver is fixed since a long time.