From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 810F93B5
 for <dev@dpdk.org>; Thu, 29 Sep 2016 18:35:00 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id w72so37758624wmf.1
 for <dev@dpdk.org>; Thu, 29 Sep 2016 09:35:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=PVWsnpk7IaAeppYzFMUe8DhLjx1oKIJyKWGlDOjFxW8=;
 b=gTSKMPN0v4cZfaEW8uf7bvtPhPKHZWcqX20UGJpnkbjwPhBjjJAc3HCjpzTOFdDZXG
 OzibhEqFR/868oVft/5DUnW+JeS9bYk78FDQzuKP8j8cOjpqjRIzaFCJE5JFj4mNqVd0
 wX8w8gloGsOE2CUAKePamDo0qLWZvDHitXx0a+2meAF2Tq8Yg4zlheYlw0hcAdjqrJ1k
 3kWbU9xzgfk03gGeLzuAXAshj5wsxMX7zK3CwzawRWALvm9yzhDoidI0CS5M4x/65lcI
 U++pybtl8u6vdnQsBJ9T1SWorq601oskuRTz28nEcRl9maSUWv05uqUAhtl12kyG8CN8
 +I+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=PVWsnpk7IaAeppYzFMUe8DhLjx1oKIJyKWGlDOjFxW8=;
 b=IO9+j5LmDbvOumpcuKk+fNG7IuHwwU+r5SQFKeQiYdFZvMw5GlJ5TblEXZLpUH5FWB
 bqrwz/VUAyXIyaoCanHDEpYSgM2YrqN/v6xB+U/BQVjPywgU8mM223YZ8dCf+SrQWyPG
 HGFWrByHLqayWrnO/O8Bm0rnqfZBKZW9jG55e3v8j/1D7ArFF16arer9YW61RDMjfvR2
 Z2P/D3UJKpxKX2f2nLAxAOEHsKFLLX3d5DCu4qfYxxs6iAV22EYaq0xybSpI45nSXZ8f
 Bs33QkJWT0Wm+iUGV9bzw9pm1iDJo21o5/MhwYgXI456qYUPQfmbMtxI1NWfSJlpyy+8
 3ZZQ==
X-Gm-Message-State: AA6/9Rm6/uQxPsI6nghwI8PojtpGGSB1yRw4PlDuEdGV8LxBlbiWemIRo6KODjee38B9jAkV
X-Received: by 10.194.137.81 with SMTP id qg17mr2243378wjb.205.1475166900340; 
 Thu, 29 Sep 2016 09:35:00 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id w207sm29097108wmd.8.2016.09.29.09.34.59
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 29 Sep 2016 09:34:59 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org
Date: Thu, 29 Sep 2016 18:34:58 +0200
Message-ID: <4122748.D2hJ4kS1ho@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 16:35:00 -0000

2016-09-30 02:54, Nikhil Rao:
> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx as the lower dword of the source
> to cmpxchg8b instead of the lower dword of function argument "src".

Could you please start the explanation with a statement of
what is wrong from an user point of view?
It could help to understand how severe it is.