From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 341CAA00C4; Thu, 31 Oct 2019 14:45:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3DE41C23F; Thu, 31 Oct 2019 14:45:45 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1DC9C2A6C for ; Thu, 31 Oct 2019 14:45:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 75F5422579; Thu, 31 Oct 2019 09:45:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 31 Oct 2019 09:45:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vU/D4BCMGflRwl4yF3L0vzJ1l219py5Ev1h6lOOMKB4=; b=WHWmGO5TnzkW Y+beHw3HvNrvJb5zIn5wryaf9B0HKP4wc+RYSJYxbyEG9TBwCne+qG/tQKx9pKXo CDUBul6wsi6arDXAFkeHTMEz7lJjB0i5CPxC0FnNTDSERstzxFI54WSwXTe/8pWq iTkw3j/Pa4bj0PP+nb8jB8HS0fT0Oi8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vU/D4BCMGflRwl4yF3L0vzJ1l219py5Ev1h6lOOMK B4=; b=KEmTFGGxmybtlbSVX3GRG1vnzpkTaLIIm7Oah3/iCFfK3HxGWwoK0KoDE n2UdHUmrlRJ7p8nSMFPqaQiGl623kBOmmWbrHHRTO56hrbvFx8+o921/PAF3xtT2 QVtn2HIxWCdHE1eHlTVWucJXioucbg1xVBl4CA4HeQpzqkdY9/l3Rl14mytZMT8B yDerCm+jMKUyPtXJa/YXmJCcGE3tQE2TUgNdLqcsIwkpabtcqL2GTujfZXLH2iKV fkODf3GwRFugxOOQU+5qNVdvoo8aFEK2OVfd53e7sXL4nQMQliASjHQtPMVeMAMh npfVGq5vhPB0kkxAcCJG+oL6CzGJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddthedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D87C68005C; Thu, 31 Oct 2019 09:45:41 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , pbhagavatula@marvell.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, jerinj@marvell.com Date: Thu, 31 Oct 2019 14:45:40 +0100 Message-ID: <4128191.2yC1yh9K1M@xps> In-Reply-To: <6a48d129-8d68-38d6-f5c3-6c2a0d96e3ce@solarflare.com> References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-4-pbhagavatula@marvell.com> <6a48d129-8d68-38d6-f5c3-6c2a0d96e3ce@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2019 17:53, Andrew Rybchenko: > On 10/29/19 6:37 PM, pbhagavatula@marvell.com wrote: > > From: Pavan Nikhilesh > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static int > > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > > I'm not sure about underscore in function name. May be Thomas or > Ferruh can comment. If it is private, don't use the rte_ prefix at all. This function can be simply named "validate_offloads".