From: "Andrzej Ostruszka [C]" <aostruszka@marvell.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library
Date: Thu, 9 Jul 2020 08:43:32 +0000 [thread overview]
Message-ID: <41291e3d-b902-46af-2915-2a76c6d89097@marvell.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C6110C@smartserver.smartshare.dk>
First of all let me thank you all one again for the time you took
looking at this and summarize your feedback as I understand it.
1. Don't use interrupt thread because in heavy load scenarios this might
cause problems.
2. Provide higher level functionality - so that application can just use
it instead of maintaining the info on their own.
3. Provide way to have control over the changes - if I remember
correctly someone wanted apps to be able to reject the changes (meaning
rolling back the changes to the kernel)
4. Don't parse netlink on your own (use e.g. libmnl)
5. Don't use callbacks
These are the specific things that I managed to understand. Have I
missed anything? If so please add this to the list!
To that I say:
Ad1. Agree, will change that.
Ad2. OK, but this can be added later.
Ad3. Currently the lib was meant to be one way but as in previous point
this can change in the future.
Ad4. As mentioned in previous mail I judged it not worthy of adding
dependency but I'm OK with using it. This might be more relevant when
we address point 3 and can be introduced then, but I can do it now.
Ad5. There are now notification queues and I'm fine with adapting to any
standard of notification/communication that DPDK will agree on.
In addition may I ask your opinion on the changes that are required
before the library can be accepted?
Thank you in advance
With regards
Andrzej Ostruszka
next prev parent reply other threads:[~2020-07-09 8:43 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:41 [dpdk-dev] [PATCH 0/4] Introduce IF proxy library Andrzej Ostruszka
2020-03-06 16:41 ` [dpdk-dev] [PATCH 1/4] lib: introduce IF Proxy library Andrzej Ostruszka
2020-03-31 12:36 ` Harman Kalra
2020-03-31 15:37 ` Andrzej Ostruszka [C]
2020-04-01 5:29 ` Varghese, Vipin
2020-04-01 20:08 ` Andrzej Ostruszka [C]
2020-04-08 3:04 ` Varghese, Vipin
2020-04-08 18:13 ` Andrzej Ostruszka [C]
2020-03-06 16:41 ` [dpdk-dev] [PATCH 2/4] if_proxy: add library documentation Andrzej Ostruszka
2020-03-06 16:41 ` [dpdk-dev] [PATCH 3/4] if_proxy: add simple functionality test Andrzej Ostruszka
2020-03-06 16:41 ` [dpdk-dev] [PATCH 4/4] if_proxy: add example application Andrzej Ostruszka
2020-03-06 17:17 ` [dpdk-dev] [PATCH 0/4] Introduce IF proxy library Andrzej Ostruszka
2020-03-10 11:10 ` [dpdk-dev] [PATCH v2 " Andrzej Ostruszka
2020-03-10 11:10 ` [dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library Andrzej Ostruszka
2020-07-02 0:34 ` Stephen Hemminger
2020-07-07 20:13 ` Andrzej Ostruszka [C]
2020-07-08 16:07 ` Morten Brørup
2020-07-09 8:43 ` Andrzej Ostruszka [C] [this message]
2020-07-22 0:40 ` Thomas Monjalon
2020-07-22 8:45 ` Jerin Jacob
2020-07-22 8:56 ` Thomas Monjalon
2020-07-22 9:09 ` Jerin Jacob
2020-07-22 9:27 ` Thomas Monjalon
2020-07-22 9:54 ` Jerin Jacob
2020-07-23 14:09 ` [dpdk-dev] [EXT] " Andrzej Ostruszka [C]
2020-03-10 11:10 ` [dpdk-dev] [PATCH v2 2/4] if_proxy: add library documentation Andrzej Ostruszka
2020-03-10 11:10 ` [dpdk-dev] [PATCH v2 3/4] if_proxy: add simple functionality test Andrzej Ostruszka
2020-03-10 11:10 ` [dpdk-dev] [PATCH v2 4/4] if_proxy: add example application Andrzej Ostruszka
2020-03-25 8:08 ` [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library David Marchand
2020-03-25 11:11 ` Morten Brørup
2020-03-26 17:42 ` Andrzej Ostruszka
2020-04-02 13:48 ` Andrzej Ostruszka [C]
2020-04-03 17:19 ` Thomas Monjalon
2020-04-03 19:09 ` Jerin Jacob
2020-04-03 21:18 ` Morten Brørup
2020-04-03 21:57 ` Thomas Monjalon
2020-04-04 10:18 ` Jerin Jacob
2020-04-10 10:41 ` Morten Brørup
2020-04-04 18:30 ` Andrzej Ostruszka [C]
2020-04-04 19:58 ` Thomas Monjalon
2020-04-10 10:03 ` Morten Brørup
2020-04-10 12:28 ` Jerin Jacob
2020-03-26 12:41 ` Andrzej Ostruszka
2020-03-30 19:23 ` Andrzej Ostruszka
2020-04-03 21:42 ` Thomas Monjalon
2020-04-04 18:07 ` Andrzej Ostruszka [C]
2020-04-04 19:51 ` Thomas Monjalon
2020-04-16 16:11 ` [dpdk-dev] [PATCH " Stephen Hemminger
2020-04-16 16:49 ` Jerin Jacob
2020-04-16 17:04 ` Stephen Hemminger
2020-04-16 17:26 ` Andrzej Ostruszka [C]
2020-04-16 17:27 ` Jerin Jacob
2020-04-16 17:12 ` Andrzej Ostruszka [C]
2020-04-16 17:19 ` Stephen Hemminger
2020-05-04 8:53 ` [dpdk-dev] [PATCH v3 " Andrzej Ostruszka
2020-05-04 8:53 ` [dpdk-dev] [PATCH v3 1/4] lib: introduce IF Proxy library Andrzej Ostruszka
2020-05-04 8:53 ` [dpdk-dev] [PATCH v3 2/4] if_proxy: add library documentation Andrzej Ostruszka
2020-05-04 8:53 ` [dpdk-dev] [PATCH v3 3/4] if_proxy: add simple functionality test Andrzej Ostruszka
2020-05-04 8:53 ` [dpdk-dev] [PATCH v3 4/4] if_proxy: add example application Andrzej Ostruszka
2020-06-22 9:21 ` [dpdk-dev] [PATCH v4 0/4] Introduce IF proxy library Andrzej Ostruszka
2020-06-22 9:21 ` [dpdk-dev] [PATCH v4 1/4] lib: introduce IF Proxy library Andrzej Ostruszka
2020-06-22 9:21 ` [dpdk-dev] [PATCH v4 2/4] if_proxy: add library documentation Andrzej Ostruszka
2020-06-22 9:21 ` [dpdk-dev] [PATCH v4 3/4] if_proxy: add simple functionality test Andrzej Ostruszka
2020-06-22 9:21 ` [dpdk-dev] [PATCH v4 4/4] if_proxy: add example application Andrzej Ostruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41291e3d-b902-46af-2915-2a76c6d89097@marvell.com \
--to=aostruszka@marvell.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).