From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
Yipeng Wang <yipeng1.wang@intel.com>,
honnappa.nagarahalli@arm.com
Cc: dev@dpdk.org, Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread
Date: Thu, 26 Nov 2020 18:56:21 +0100 [thread overview]
Message-ID: <4130571.hpL29E20KA@thomas> (raw)
In-Reply-To: <1609609.4PBobdEyhI@thomas>
16/06/2020 18:12, Thomas Monjalon:
> 05/06/2020 20:35, Stephen Hemminger:
> > On Thu, 4 Jun 2020 10:17:31 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > > The code in rte_cuckoo_hash multi-writer support is broken if write
> > > operations are called from a non-EAL thread.
> > >
> > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL
> > > thread and that leads to using wrong local cache.
> > >
> > > Add error checks and document the restriction.
> > >
> > > Fixes: 9d033dac7d7c ("hash: support no free on delete")
> > > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention")
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > Cc: honnappa.nagarahalli@arm.com
> > > Cc: pablo.de.lara.guarch@intel.com
> >
> > This restriction also needs to be added to the known issues
> > section of EAL
>
> Are you going to send a v2 adding doc?
Any follow-up?
prev parent reply other threads:[~2020-11-26 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:17 Stephen Hemminger
2020-06-04 17:51 ` Honnappa Nagarahalli
2020-06-04 17:58 ` Stephen Hemminger
2020-06-04 18:43 ` Honnappa Nagarahalli
2020-06-04 19:10 ` Wang, Yipeng1
2020-06-04 19:34 ` Honnappa Nagarahalli
2020-06-04 20:22 ` Wang, Yipeng1
2020-06-04 21:06 ` Stephen Hemminger
2020-06-04 21:32 ` Wang, Yipeng1
2020-06-05 18:35 ` Stephen Hemminger
2020-06-16 16:12 ` Thomas Monjalon
2020-11-26 17:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4130571.hpL29E20KA@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).