From: Thomas Monjalon <thomas@monjalon.net>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/metrics: fix silent fail when uninitialised
Date: Thu, 26 Jul 2018 20:29:30 +0200 [thread overview]
Message-ID: <4143071.v8a4Ec99S8@xps> (raw)
In-Reply-To: <20180702145547.8376-1-remy.horton@intel.com>
02/07/2018 16:55, Remy Horton:
> If rte_metrics_init() had not been called and hence the internal
> metric storage is not allocated, rte_metrics_get_values() and
> rte_metrics_get_name() would silently fail by returning zero
> (i.e. no metrics registered). This patch changes the result of
> this scenario to an explicit fail by returning -EIO.
>
> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-07-26 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 14:55 Remy Horton
2018-07-26 18:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4143071.v8a4Ec99S8@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).