From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org, "Dumitrescu,
Cristian" <cristian.dumitrescu@intel.com>,
zhuangwj@gmail.com
Subject: Re: [dpdk-dev] [PATCH] port: fix build when KNI support is not enabled
Date: Mon, 27 Jun 2016 12:25:15 +0200 [thread overview]
Message-ID: <4144844.UPsiVPEqBF@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A0C1E6@IRSMSX108.ger.corp.intel.com>
> > Commit 9fc37d1c071c is missing a conditional in the dependencies,
> > causing builds to fail when KNI is not enabled:
> > == Build lib/librte_port
> > LD librte_port.so.3
> > /usr/bin/ld: cannot find -lrte_kni
> > collect2: error: ld returned 1 exit status
> >
> > Fixes: 9fc37d1c071c ("port: support KNI")
> >
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
A cleanup of the makefiles is welcome, as discussed in this thread,
to remove useless reference to their own config variable.
prev parent reply other threads:[~2016-06-27 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 11:34 Panu Matilainen
2016-06-22 11:49 ` Thomas Monjalon
2016-06-22 11:57 ` Olivier Matz
2016-06-22 12:20 ` Thomas Monjalon
2016-06-22 15:32 ` Olivier Matz
2016-06-23 8:53 ` Bruce Richardson
2016-06-23 8:59 ` Olivier Matz
2016-06-23 17:19 ` Dumitrescu, Cristian
2016-06-27 10:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4144844.UPsiVPEqBF@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=zhuangwj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).