From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id B156E58D4 for ; Mon, 27 Jun 2016 12:25:16 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v199so93946132wmv.0 for ; Mon, 27 Jun 2016 03:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ikz5qQK4ecKIZcRXXAqUBcxLIyYVmDNfmC8EhHbKWRQ=; b=1HCIm9CFD2bP6fctjLu/Z24OuJhljb5U3X4cN6MkQdCwrkVJXgJlDe74cXCPMQTfgA KEGM0clin2o5bjcWhndH2FQHB46FHlQxWMyTx6gB9LklhszEscd3HUunP50qXaQprj7d DjPdEmpyzi8zZzoUxHwV7vvHMZJCaWKBq0CzMfm9dZAuIPYa59+ukf5qoGGBEa3bldPb xYz8PC6n4Ez1fvHqgzntaL2TwNVO2VvlxGSVIJsM177vYE0Io7xDKRv30hh/4S3tDCZo PRnG4xhzDMaZAzCcmMNjocN8CPbg9+gLqBYO1761M5Z73Y9NieZhlky6/qh41JztkCG8 d+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ikz5qQK4ecKIZcRXXAqUBcxLIyYVmDNfmC8EhHbKWRQ=; b=GtU7v1gZOPuBU6jXFg/kd7o3Vv/hpITCy9tuZqFJrTs52MdjsaLQjFf8NhXJLOxh59 0AyLHCgsBtYgrA98hKAKnmziu3CjdqkBVgQ9zZrAM7u0NVD8Iun77DQ+L2nEXOtw9EQt 6HdajDg7OSpbq1KiDtXBoi7RprYX+t5jDobLWtnEZ414EbfT9NN1o2cDtKv/vyNRfyK0 2dbGAuqnIdJdr+sPFNgVP3+Kh4Xl72HRtOD3Bz436mZ8neTg5JOiUwGNnvdyM61lSogo LitGRC7+rGXlKKgbbqQh9neIzDZFs97YRgScSsA3f5uZ8c8le+DnQZURzcpjIQXUVT5J J3WA== X-Gm-Message-State: ALyK8tK6ymylfA4M3HgDBqxCt61d3XNYp/V6jnZ5iYYV5Sl2DG+qoDZOAQ2bJMrjPLgPNqzL X-Received: by 10.28.227.136 with SMTP id a130mr10282481wmh.3.1467023116533; Mon, 27 Jun 2016 03:25:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id x83sm1047135wmx.9.2016.06.27.03.25.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 03:25:15 -0700 (PDT) From: Thomas Monjalon To: Panu Matilainen Cc: dev@dpdk.org, "Dumitrescu, Cristian" , zhuangwj@gmail.com Date: Mon, 27 Jun 2016 12:25:15 +0200 Message-ID: <4144844.UPsiVPEqBF@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A0C1E6@IRSMSX108.ger.corp.intel.com> References: <191edb8105649612fab5f0e691f587715b78e664.1466595242.git.pmatilai@redhat.com> <3EB4FA525960D640B5BDFFD6A3D8912647A0C1E6@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] port: fix build when KNI support is not enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 10:25:16 -0000 > > Commit 9fc37d1c071c is missing a conditional in the dependencies, > > causing builds to fail when KNI is not enabled: > > == Build lib/librte_port > > LD librte_port.so.3 > > /usr/bin/ld: cannot find -lrte_kni > > collect2: error: ld returned 1 exit status > > > > Fixes: 9fc37d1c071c ("port: support KNI") > > > > Signed-off-by: Panu Matilainen > > Acked-by: Cristian Dumitrescu Applied, thanks A cleanup of the makefiles is welcome, as discussed in this thread, to remove useless reference to their own config variable.