From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B97A0C4E; Mon, 25 Oct 2021 21:14:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A12441144; Mon, 25 Oct 2021 21:14:26 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id C573C41141 for ; Mon, 25 Oct 2021 21:14:24 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 19D2232021ED; Mon, 25 Oct 2021 15:14:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Oct 2021 15:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= IzG+o2sy23IQCOJ7UPkrTh0PhkCv+DG6yjG6eMgcz9c=; b=lkXe//YECiSqfWVq 2A2iJwOxlxe4395IhvXPutS/buzOsRRL24vIVun7/GDrFqFRjMKJOlM02DUkY7M7 CDlIN2GG2RxJYYFQaqSFzOd8ZAqSPOq75wrX1N/PKR6uT8Zi+ncuykj442bjEck2 U5/aomvjoCKAU+F8fcw1cgNx0jG+2yFqqm/T0o+VC3cYdP4GHy5ANyp6zsZQnWAh 4aRZpTz7D/5K0ARDibgH1NazNddsH8x+Nlgpg3rh4wKiHdGqZg+t/PsY9dAQfFl+ euFVoOYp5x2qX9Xjm7OVQTzE6Y00J/lparkiszgpX95HOwMswla3Su8+4UTotc6X 6lpZRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IzG+o2sy23IQCOJ7UPkrTh0PhkCv+DG6yjG6eMgcz 9c=; b=DqTM8cdeO4m8gUmzZ7LN88xuvxtb5DzSuXiaMgFJJP75xYmtJCWmhQodx SH5v6rvO0/ZWc5aRKRoQjDBMMnQ5wKv/WVitiqbUAIKp4NLIHbgB13E0rw2kE0vF B+fwPr5XEsDP8/wB37LZ+uChpWXa4bu97KU5JpHivH56rpX0TbVPUBaxpfFaobQd 0aa6c19KPAvfMV2lmzF+DTU44nB4kQbYrVnu2aOO/fReM+VRJFmbNufyazoCGIjp h+OuMyMp4Pv5rjzJVU2hWv9/A/P6UV0j7qMlKB+jPs1+uZAJMxrb5mZ9QxG3r/kw Gal8J02Mibbx2qECQAgqv9VDhzvrg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefhedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeffvdffjeeuteelfeeile duudeugfetjeelveefkeejfeeigeehteffvdekfeegudenucffohhmrghinhepughpughk rdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Oct 2021 15:14:19 -0400 (EDT) From: Thomas Monjalon To: stephen@networkplumber.org, Tyler Retzlaff Cc: dev@dpdk.org, anatoly.burakov@intel.com, ranjit.menon@intel.com, mb@smartsharesystems.com, mdr@ashroe.eu, david.marchand@redhat.com, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com Date: Mon, 25 Oct 2021 21:14:17 +0200 Message-ID: <4152307.NZnTyprsWH@thomas> In-Reply-To: <1615836878-23213-1-git-send-email-roretzla@linux.microsoft.com> References: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> <1615836878-23213-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/03/2021 20:34, Tyler Retzlaff: > The proposal has resulted from request to review [1] the following > functions where there appeared to be inconsistency in return type > or parameter type selections for the following inline functions. > > rte_bsf32() > rte_bsf32_safe() > rte_bsf64() > rte_bsf64_safe() > rte_fls_u32() > rte_fls_u64() > rte_log2_u32() > rte_log2_u64() > > [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html > > Signed-off-by: Tyler Retzlaff > --- > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > +* eal: Fix inline function return and parameter types for rte_{bsf,fls} > + inline functions to be consistent. > + Change ``rte_bsf32_safe`` parameter ``v`` from ``uint64_t`` to ``uint32_t``. > + Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``. > + Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``. > + Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``. It seems we completely forgot this. How critical is it?