From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-yw0-f178.google.com (mail-yw0-f178.google.com
[209.85.161.178]) by dpdk.org (Postfix) with ESMTP id 7A95211DE
for <dev@dpdk.org>; Thu, 13 Oct 2016 16:01:41 +0200 (CEST)
Received: by mail-yw0-f178.google.com with SMTP id w3so53830877ywg.1
for <dev@dpdk.org>; Thu, 13 Oct 2016 07:01:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=gPHRSs4FgnzkJDx96cWnnkvqpAGApcd16QGT1UgOVA8=;
b=aWLxwSMlYtyKj43ApJSnKbQ4Chy9qFjaPUByadMWypR8d/nSHnpZS2fIZzc8cXbWeI
GInwKK8vTKtK0NbHpvTGpU2qc+opUzyBgQPGr/evvK08nLe3bMMWFUEtqtRU9YGvBsNw
7G6w28Cg4MWrUlyv346/NssmQiE/xHJm5d7jFJL4jr133PQxK8A85ps17Q5Kpe+j6lBi
Hh5WgHQeb5Hw53G/znTxgBMC6f8vaZ1aRHqdlY1Gc3IoSx9ApVuYzdLhqIviaXx12dH4
1gZ8I1MnF/EtLHIEADMbd3gCacXD9cyA3gOWI6tkXKeN4wxaep6oUu5oq1MCY5kk8jLh
NV3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=gPHRSs4FgnzkJDx96cWnnkvqpAGApcd16QGT1UgOVA8=;
b=ATns5aiMji30rHquIICOnAZrYAuqlzQ3ssJ5k00HOsA27LTHk/2QawGxhgvZlXNHgN
dgDazr7HWBJJrshOeAMww7QK6GPrAVLSRGAl6fIUVfzRmOY9yJG9QKJhXURcVBvUwlI4
H1/xPrQ/17LDHhaR2TXtv/LTxd6pV3sWx3v/BtblSoNh86sgGdndAMo01UGsvUVkisoV
GXgn8BAmZqMBhQtsbu06C4pxjvxc3Vy+66VKFIgiC1EmdB6T1a+FR8pSGHwMp9N9wFl8
5H+Rjw9MFFoOCzau44RZFMetVAmKZsykw8pHrWCSwI7m+Fnsy7i3CA9MfnOEkG2V7w3Q
TBMw==
X-Gm-Message-State: AA6/9RmfctD0M7eyF284SJYDPAs71ri/U5NkQM5LQ//ZCoJLgw0JDjCOO9FSEPrO2bB8E0k7
X-Received: by 10.28.13.84 with SMTP id 81mr2307215wmn.102.1476367299276;
Thu, 13 Oct 2016 07:01:39 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id pe5sm22857990wjb.15.2016.10.13.07.01.38
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 13 Oct 2016 07:01:38 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
Date: Thu, 13 Oct 2016 16:01:37 +0200
Message-ID: <4155546.K4Q8W0cgmd@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1476366030-28321-1-git-send-email-olivier.matz@6wind.com>
References: <1476366030-28321-1-git-send-email-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix tso with csum engine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2016 14:01:41 -0000
2016-10-13 15:40, Olivier Matz:
> The commit that disabled tso for small packets was broken during the
> rebase. The problem is the IP checksum is not calculated in software if:
> - TX IP checksum is disabled
> - TSO is enabled
> - the current packet is smaller than tso segment size
>
> When checking if the PKT_TX_IP_CKSUM flag should be set (in case
> of tso), use the local tso_segsz variable, which is set to 0 when the
> packet is too small to require tso. Therefore the IP checksum will be
> correctly calculated in software.
>
> Moreover, we should not use tunnel segment size for non-tunnel tso, else
> TSO will stay disabled for all packets.
>
> Fixes: 97c21329d42b ("app/testpmd: do not use TSO for small packets")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks