From: Thomas Monjalon <thomas@monjalon.net>
To: dev <dev@dpdk.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [dpdk-dev] [PATCH] vfio: fix stdbool usage without include
Date: Tue, 01 Jun 2021 09:25:09 +0200 [thread overview]
Message-ID: <4162591.McMD3bK3sO@thomas> (raw)
In-Reply-To: <20210601054247.1540154-1-christian.ehrhardt@canonical.com>
01/06/2021 07:42, Christian Ehrhardt:
> This became visible by backporting the following for the 19.11 stable tree:
> c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA"
>
> The usage of type bool in the vfio code would require "#include
> <stdbool.h>", but rte_vfio.h has no direct paths to stdbool.h.
> It happens that in eal_vfio_mp_sync.c it comes after "#include
> <rte_log.h>".
>
> And rte_log.h since 20.05 includes stdbool since this change:
> 241e67bfe "log: add API to check if a logtype can log in a given level"
> and thereby masks the issue in >20.05.
>
> It should be safe to include stdbool.h from rte_vfio.h itself
> to have bool present exactly when needed for the struct it defines
> using that type.
A line "Fixes" is missing for the record of the root cause.
next prev parent reply other threads:[~2021-06-01 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 5:42 Christian Ehrhardt
2021-06-01 7:25 ` Thomas Monjalon [this message]
2021-06-01 7:43 ` Christian Ehrhardt
2021-06-01 8:28 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2021-06-02 11:06 ` Burakov, Anatoly
2021-06-17 15:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4162591.McMD3bK3sO@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).