From: Thomas Monjalon <thomas@monjalon.net>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
ajit.khaparde@broadcom.com
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation
Date: Sun, 24 May 2020 17:34:15 +0200 [thread overview]
Message-ID: <4164380.5S5RWRVCr3@thomas> (raw)
In-Reply-To: <1629576.oqx4rD5t72@thomas>
Somnath, why neither update, nor reply to reviews after February 7?
It is discouraging for reviewers.
24/04/2020 20:24, Thomas Monjalon:
> Please Somnath, it is waiting for a v2.
>
>
> 26/02/2020 01:55, Stephen Hemminger:
> > On Fri, 7 Feb 2020 15:29:59 +0100
> > Olivier Matz <olivier.matz@6wind.com> wrote:
> >
> > > The meaning of each flag should be as simple as possible, I think we can
> > > summarize them like this:
> > >
> > > - PKT_RX_VLAN: the vlan is saved in vlan tci.
> > > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data.
> > > - PKT_RX_QINQ: the outer vlan is saved in vlan tci.
> > > - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data.
> > > - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan
> > > of initial packet, else it refers to the first vlan of the packet.
> > >
> > > There is a link between vlan flag and vlan_tci field, and qinq flag and
> > > vlan_tci_outer field.
> > >
> > > I'm still not sure to understand what you expect. Can you give an
> > > example with flags (which are set), and the expected content of m->vlan_tci
> > > and m->vlan_tci_outer?
> > >
> > > By the way, the case 5/ is not very well described too, maybe we should
> > > add something about it.
> > >
> > > Thanks,
> > > Olivier
> >
> > The patch does help clarify the meaning, and Oliver's summary clarifies
> > even more. It might be possible for hardware to offload inner vlan but
> > not outer vlan, though seriously doubt anyone but some conformance test
> > would do that.
next prev parent reply other threads:[~2020-05-24 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 8:34 Somnath Kotur
2020-02-06 16:27 ` Somnath Kotur
2020-02-06 17:25 ` Olivier Matz
2020-02-07 13:43 ` Somnath Kotur
2020-02-07 14:29 ` Olivier Matz
2020-02-26 0:55 ` Stephen Hemminger
2020-04-24 18:24 ` Thomas Monjalon
2020-05-24 15:34 ` Thomas Monjalon [this message]
2020-06-11 6:11 ` Thomas Monjalon
2020-04-25 13:08 ` Andrew Rybchenko
2020-10-06 7:22 ` [dpdk-dev] [PATCH v2] mbuf: extend meaning of QinQ stripped bit Olivier Matz
2020-10-08 13:13 ` David Marchand
2020-10-12 8:20 ` Andrew Rybchenko
2020-10-15 20:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4164380.5S5RWRVCr3@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).