From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AB95A04A4; Sun, 24 May 2020 17:34:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 393421D44C; Sun, 24 May 2020 17:34:20 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 487C61D154 for ; Sun, 24 May 2020 17:34:19 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 0FE2A6F3; Sun, 24 May 2020 11:34:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 24 May 2020 11:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 4nZo626YDY9PtfwxEH6jRROd/yOtjLPy5GJJI3TLrTQ=; b=c+IbHKY5vUEZO5RJ F8zUSmAGjCBajXZSoSp8JbGKDidkaNEnaSQQjOGO7SQsonx8zVdxVyE2f56FB5sV 3bnNPeAEUZHW+c+xXa+ag8W7DiVemSmq5FqtpYkHw9oyU30v/VR4AVZJVRsR0TKH erxi1FEgAKHGe8MtVTuobSp6bQWvyT5R6o8TIYaEJ8OpZD4rrrWR2vNTVSPEnkuh l2mDjPQVYm0mJuV5DsKqF6V3xL8YJnme9YhgynZErw97JfZwslO6we8zG9JJnRth rpgkloXzvnzYKTXmqJeZID5AnTb25lsHcwcfqRcqJCWrKk5Sfry2t/eudfdBBpdK VLAy7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4nZo626YDY9PtfwxEH6jRROd/yOtjLPy5GJJI3TLr TQ=; b=apzThJxz5Ug7OxcXziRzM3mQm2bG6f9Y1V6PONGxc4vgX+uyTXyj1SPry eVrU9JT0bYzZ3sN71wRzQi4bTw8Nf5DJ+iEPhhyOnuIfYeZAD0cy7E5eSrp/RIah cRr2VppD/SGNdUtNcaB0yXMhEuXC5UT0XI0XOQk9b+UjTQPSnrabwjmgPUysmfun uAMI0r923rb7ZcdClxmwRKm0EPlaVgzwKGHrtnMG4kxrigxR8pp96EJr6re7QI8q M5veh4/PjdiUwa1HqaAVxjS/am+9Ctab3NOLbh40na/aVtT1GRij5uGykuZ7iXFC 0IfdXIZL5VvICSVyM1LyGy3nZH55Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DDA83066526; Sun, 24 May 2020 11:34:16 -0400 (EDT) From: Thomas Monjalon To: Somnath Kotur Cc: dev@dpdk.org, Olivier Matz , Ferruh Yigit , Stephen Hemminger , ajit.khaparde@broadcom.com Date: Sun, 24 May 2020 17:34:15 +0200 Message-ID: <4164380.5S5RWRVCr3@thomas> In-Reply-To: <1629576.oqx4rD5t72@thomas> References: <20200106083423.26600-1-somnath.kotur@broadcom.com> <20200225165541.01c06952@hermes.lan> <1629576.oqx4rD5t72@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Somnath, why neither update, nor reply to reviews after February 7? It is discouraging for reviewers. 24/04/2020 20:24, Thomas Monjalon: > Please Somnath, it is waiting for a v2. > > > 26/02/2020 01:55, Stephen Hemminger: > > On Fri, 7 Feb 2020 15:29:59 +0100 > > Olivier Matz wrote: > > > > > The meaning of each flag should be as simple as possible, I think we can > > > summarize them like this: > > > > > > - PKT_RX_VLAN: the vlan is saved in vlan tci. > > > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data. > > > - PKT_RX_QINQ: the outer vlan is saved in vlan tci. > > > - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data. > > > - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan > > > of initial packet, else it refers to the first vlan of the packet. > > > > > > There is a link between vlan flag and vlan_tci field, and qinq flag and > > > vlan_tci_outer field. > > > > > > I'm still not sure to understand what you expect. Can you give an > > > example with flags (which are set), and the expected content of m->vlan_tci > > > and m->vlan_tci_outer? > > > > > > By the way, the case 5/ is not very well described too, maybe we should > > > add something about it. > > > > > > Thanks, > > > Olivier > > > > The patch does help clarify the meaning, and Oliver's summary clarifies > > even more. It might be possible for hardware to offload inner vlan but > > not outer vlan, though seriously doubt anyone but some conformance test > > would do that.