From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3DA7A37A0
 for <dev@dpdk.org>; Thu, 29 Jun 2017 22:58:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A2C2820707;
 Thu, 29 Jun 2017 16:58:57 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 29 Jun 2017 16:58:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=gsiMM1q1D0QKMOM
 a5/YQdRIvwZ/2mNlz+MFOpWs0/B4=; b=RHE/0XejSNnpnhtbDmVIbCb2/Twjhg9
 qyywaC9P9MGHYkPGPB1asMeP9PSm89KAL00MbfOUuPBFM5O7jUZ7UZj49zOIoRCB
 M53LMkM1MdTIkQw2OKGm1rPvAf/+IT9Uio0dkRlCEkvITIn4ybp9pmYRv1uUxxkp
 1C2weF785sOw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=gsiMM1q1D0QKMOMa5/YQdRIvwZ/2mNlz+MFOpWs0/B4=; b=BW6QMlXg
 6eABxjnIgN18ekOM9+Szdo51J+B5/OeWGY5WYmhsbFd45xNtnwEDI494QKVE1Jw6
 E/CHOXk6V9kWPzVNH2zfbTyXavk7dDdxP2bzxSSmPZz/opSHBi1d3NKzDgY7IFsq
 td4KPNWtihcMeX5smaSmv3h8h7ZUKhu++XT1fR4CUff1iLPyyg9vocVWFMRjC8ZO
 TEu+WcjHeBMW7NfwoGX7bc/mYCuZI/JeKCH5b83qQHGp4C+t5l0p7g2hX7XRtkEN
 lyHKGEGQp0qb6QmisIxZmAKu7rEFDmfVDg8GKExb+iFCUVcTt+nOSoxq4f8W3FwB
 qhc2cq9P/M7Y2A==
X-ME-Sender: <xms:EWpVWYY_h7xp2xi0uHSot3xIviHy1x6oIYuO-jmDYtY_yOGdLiuEHA>
X-Sasl-enc: skF1DxQeVK5DDkAkWlF2hqudHtRoO9xIl5wftFb2kUNQ 1498769937
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 253427E51B;
 Thu, 29 Jun 2017 16:58:57 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com
Date: Thu, 29 Jun 2017 22:58:56 +0200
Message-ID: <41661112.fj3Og5vZkG@xps>
In-Reply-To: <20170629182206.1072-16-jblunck@infradead.org>
References: <cover.1498577192.git.gaetan.rivet@6wind.com>
 <20170629182206.1072-1-jblunck@infradead.org>
 <20170629182206.1072-16-jblunck@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 15/15] ethdev: Use embedded rte_device to
	detach driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 20:58:58 -0000

29/06/2017 20:22, Jan Blunck:
> --- a/lib/librte_eal/common/eal_common_dev.c
> +++ b/lib/librte_eal/common/eal_common_dev.c
> +int rte_eal_device_detach(struct rte_device *dev)
[...]
>  int rte_eal_dev_detach(const char *name)

I would be in favor of breaking the API without notice,
and keep the name rte_eal_dev_detach for the function
taking a rte_device as parameter.
This function was introduced in 16.11 and has probably never been used,
except in ethdev and testpmd. Legacy apps probably use rte_eth_dev_detach.