From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 031E7A00C5; Sun, 26 Apr 2020 20:07:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B73671C121; Sun, 26 Apr 2020 20:07:02 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 8E7591C0DA for ; Sun, 26 Apr 2020 20:07:01 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 527CC473; Sun, 26 Apr 2020 14:06:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 14:06:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= uDrVgWI1CIeMVrBF6VyO7aL1ExZCUfSqRiIZDEEjWjA=; b=eZGa+XBrIUJ4QZ0t 67TpkU/GrwUFo6gBAyINA29Oy6Z8/AisbirJezRbocIrhOe9SmUxiG3UK6mmb2IW YWTF/z5k5vt6et2IAS4R5w5EOsBMQGgwW6kqoGc9vUFmfdP4Zx1ZpRIO9VO5GaTG tgpXxje3acoUtrqkR/orbaT1/rQjCLGTQrmaKIxMwKsr5g15LHh0BKju4XY6owTm lZ5txBH1QAWtG9FMyFypGIHFx2PoVIszlVktGdd8P74R3bxE6kkk2BJ2CeABJe0J SVwn0Ug49/Fpx0QGn+X0rv+mAmftW6MWGTN9Yye1jjBv5tgrBWe+ycLgFMX5JgGM 5Puucw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uDrVgWI1CIeMVrBF6VyO7aL1ExZCUfSqRiIZDEEjW jA=; b=DlwsqE12jLyesg5MOK63c3GdvkGQaLgTSbQe8dcEb/pblE7ieHAU/I8N4 ZhXBzpgRakTGP503TwpFGcoMBwRyXUsm1XAK6nsWaf52Vy1hXedB4EyohCSrn0U/ /o7s0c/ZfJhOkFMZJcExxKaNRjEe2WJ0IS4GVr7nsG0olZknz1R4f8d8n+PP5gOD YhVDe5yQDS2ag2LtcQnT8JQFwvrV42qpuKUUBWPoCrWInX62ZFT+D2vevEVVWOey HM7aHFJRMLQRpSx7QXDv4N+z2PNM2sYEhWa6LixbsKvIeKmb2csq0l3ludTjMhSk o8ypyngfHi4ClDsHoXC1Or3NDF8FQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E50C3065E2A; Sun, 26 Apr 2020 14:06:57 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Jerin Jacob , dpdk-dev , Olivier Matz Date: Sun, 26 Apr 2020 20:06:55 +0200 Message-ID: <4168892.bm5RmrZB5H@thomas> In-Reply-To: References: <20200121080021.2835490-1-jerinj@marvell.com> <7318372.iedYuu7f5S@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/04/2020 19:42, Jerin Jacob: > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon wrote: > > 06/02/2020 15:36, Jerin Jacob: > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon wrote: > > > > 21/01/2020 09:00, jerinj@marvell.com: > > > > > From: Jerin Jacob > > > > > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe > > > > > creates a lot of clutter on boot-up, typically one needs > > > > > to scroll the screen to find other issues in boot-up. > > > > > > > > > > This patch changes the loglevel of PCI probes to `debug` > > > > > to reduce the clutter on default boot-up logs > > > > > > > > I think the PCI probe informations are... informational. > > > > Maybe you are just not interested in info logs. > > > > If this is the case, I suggest to change the log level at runtime. > > > > > > I am wondering, what would be the right balance, Following is DPDK > > > startup output from octeontx2[1] > > > It creates a lot of clutter in the "default" boot up. Why not enable > > > below prints using log level at runtime? > > > I believe it comes as a debug category, i.e information required to > > > debug if something is not working, > > > dpdk bind script already lists what is bound to DPDK. > > > > > > Suggestion to remove clutter? > > > > I suggest using dynamic log level in the PCI driver. > > Unfortunately a lot of old DPDK code is still using the old log macros. > > Some cleanup work is needed here. > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE. No, a PCI PMD can work without a known kernel driver. This is the case of mlx4/mlx5. > I think that is the source of the problem. > http://patches.dpdk.org/patch/69351/ The source of the problem is just changing log levels dynamically is not possible currently with PCI driver logs.