DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	ci@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
	Stefan Sundkvist <stefan.sundkvist@ericsson.com>,
	"Ola.Liljedahl@arm.com" <Ola.Liljedahl@arm.com>
Subject: Re: [dpdk-dev] [dpdk-ci] [EXT] [PATCH 0/8] DSW performance and statistics improvements
Date: Wed, 15 Apr 2020 19:45:33 +0200	[thread overview]
Message-ID: <4169023.2VHbPRQshP@thomas> (raw)
In-Reply-To: <3b11e98c-b270-0e85-bc9e-e0cf32f7cbb4@ericsson.com>

15/04/2020 19:39, Mattias Rönnblom:
> On 2020-04-15 18:37, David Marchand wrote:
> > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com> wrote:
> >> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >>> Performance and statistics improvements for the distributed software
> >>> (DSW) event device.
> >>>
> >>> Mattias Rönnblom (8):
> >>>    event/dsw: reduce latency in low-load situations
> >>>    event/dsw: reduce max flows to speed up load balancing
> >>>    event/dsw: extend statistics
> >>>    event/dsw: improve migration mechanism
> >>>    event/dsw: avoid migration waves in large systems
> >>>    event/dsw: remove redundant control ring poll
> >>>    event/dsw: remove unnecessary read barrier
> >>>    event/dsw: add port busy cycles xstats
> >> Series applied to dpdk-next-eventdev/master. Thanks.
> > 
> > I get a compilation issue on rhel7.
> > Too bad the CI did not help.
> > https://protect2.fireeye.com/v1/url?k=6777ccba-3ba3c0e4-67778c21-8691959ed9b7-56149d0a5dee8fea&q=1&e=d034618d-5861-42ba-adf3-fc0aafd4892a&u=http%3A%2F%2Fpatchwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D8828%26state%3D%2A
> >
> >
> > [1583/1808] Compiling C object
> > 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'.
> > ../drivers/event/dsw/dsw_event.c: In function ‘dsw_port_consider_emigration’:
> > ../drivers/event/dsw/dsw_event.c:502:27: warning: ‘candidate_qf’ may
> > be used uninitialized in this function [-Wmaybe-uninitialized]
> >    target_qfs[*targets_len] = *candidate_qf;
> >                             ^
> > ../drivers/event/dsw/dsw_event.c:445:25: note: ‘candidate_qf’ was declared here
> >    struct dsw_queue_flow *candidate_qf;
> >                           ^
> > In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0,
> >                   from ../lib/librte_eal/include/generic/rte_rwlock.h:25,
> >                   from ../lib/librte_eal/x86/include/rte_rwlock.h:12,
> >                   from ../lib/librte_eal/include/rte_fbarray.h:40,
> >                   from ../lib/librte_eal/include/rte_memory.h:25,
> >                   from ../lib/librte_eventdev/rte_event_ring.h:20,
> >                   from ../drivers/event/dsw/dsw_evdev.h:8,
> >                   from ../drivers/event/dsw/dsw_event.c:5:
> > ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning:
> > ‘candidate_flow_load’ may be used uninitialized in this function
> > [-Wmaybe-uninitialized]
> >    __sync_fetch_and_add(&v->cnt, inc);
> >                        ^
> > ../drivers/event/dsw/dsw_event.c:448:10: note: ‘candidate_flow_load’
> > was declared here
> >    int16_t candidate_flow_load;
> >            ^
> > ../drivers/event/dsw/dsw_event.c:505:49: warning: ‘candidate_port_id’
> > may be used uninitialized in this function [-Wmaybe-uninitialized]
> >    rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load,
> >                                                   ^
> > ../drivers/event/dsw/dsw_event.c:446:10: note: ‘candidate_port_id’ was
> > declared here
> >    uint8_t candidate_port_id;
> >            ^
> >
> 
> Looks like a false positive. What GCC version is this?

This is with RHEL 7.
Please do you have such distro to test and fix the false positive?
A quick fix would be very welcome.



  reply	other threads:[~2020-04-15 17:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  6:50 [dpdk-dev] " Mattias Rönnblom
2020-03-09  6:50 ` [dpdk-dev] [PATCH 1/8] event/dsw: reduce latency in low-load situations Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 2/8] event/dsw: reduce max flows to speed up load balancing Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 3/8] event/dsw: extend statistics Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 4/8] event/dsw: improve migration mechanism Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 5/8] event/dsw: avoid migration waves in large systems Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 6/8] event/dsw: remove redundant control ring poll Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 7/8] event/dsw: remove unnecessary read barrier Mattias Rönnblom
2020-03-09  6:51 ` [dpdk-dev] [PATCH 8/8] event/dsw: add port busy cycles xstats Mattias Rönnblom
2020-04-04 14:35 ` [dpdk-dev] [EXT] [PATCH 0/8] DSW performance and statistics improvements Jerin Jacob Kollanukkaran
2020-04-15 16:37   ` David Marchand
2020-04-15 17:39     ` Mattias Rönnblom
2020-04-15 17:45       ` Thomas Monjalon [this message]
2020-04-15 18:09         ` [dpdk-dev] [dpdk-ci] " Mattias Rönnblom
2020-04-15 18:15           ` [dpdk-dev] [PATCH v2] event/dsw: fix gcc 4.8 false positive warning Mattias Rönnblom
2020-04-15 19:45             ` David Marchand
2020-04-16  6:15               ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4169023.2VHbPRQshP@thomas \
    --to=thomas@monjalon.net \
    --cc=Ola.Liljedahl@arm.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stefan.sundkvist@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).