From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5B86A0563; Wed, 15 Apr 2020 19:45:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9DD41D993; Wed, 15 Apr 2020 19:45:38 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 340AD1D8DC; Wed, 15 Apr 2020 19:45:37 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7E8325C014D; Wed, 15 Apr 2020 13:45:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 15 Apr 2020 13:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=QdQyUC/xI2bgHlVGLDZSXnPIzN4Hr7MTRGBB1E6LBBQ=; b=jPDPF2BEmq4o OqdSMDuyvN9giKZLO1f/qguzmSyjG8dFsOMgyxALZf0MgvYKVhA9VDKK1YCgpd+D BkaoPBF7N9G1nBKHf4PPbhYEdBYc/RhPe3ZR1WK/znY2fjCsdFwTXm+4/Sl8YnsE BYlBe6bSAu8ZEiK0a4Z95XViWPqCKBc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QdQyUC/xI2bgHlVGLDZSXnPIzN4Hr7MTRGBB1E6LB BQ=; b=ZoOs2D8B6XChRdHRclgm2/b/ESLg+YRyNkOE7xZgAdgU9R8rupb2aXaDf YXU24XrYSQya+0bOwbv8Qe/DvP8QTucQbqZ5MZlZa/C/ru8c7DTDRooww55SYjcZ XHBguR97v6W8Hc4I1aW9yzUr9Ju3TcGtY9YpUkliQkl1bna+1tpSJ1ja7J/WgWVw 7Iv3t+Q08QyfsrBd4IDi67jQZTWHjkuXpcMcSQ5jM0o8+S0tF3PMZF6bAFArM0ZV 2z7/KjLqEQHPBGanvBkqYxwjIf3a7QQ+riFtVggWIKQwSHIbzcf76JXSf5iAsQIT xYh9JDjY+RFf5gyV8QQGIJxPvW0kw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeefgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfihhrvggvhigvrdgtohhmpdguphgukhdrohhrghenucfkphepjeejrddu feegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 761B13280060; Wed, 15 Apr 2020 13:45:34 -0400 (EDT) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= Cc: David Marchand , Jerin Jacob Kollanukkaran , ci@dpdk.org, "dev@dpdk.org" , Stefan Sundkvist , "Ola.Liljedahl@arm.com" Date: Wed, 15 Apr 2020 19:45:33 +0200 Message-ID: <4169023.2VHbPRQshP@thomas> In-Reply-To: <3b11e98c-b270-0e85-bc9e-e0cf32f7cbb4@ericsson.com> References: <20200309065106.23800-1-mattias.ronnblom@ericsson.com> <3b11e98c-b270-0e85-bc9e-e0cf32f7cbb4@ericsson.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-ci] [EXT] [PATCH 0/8] DSW performance and statistics improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2020 19:39, Mattias R=C3=B6nnblom: > On 2020-04-15 18:37, David Marchand wrote: > > On Sat, Apr 4, 2020 at 4:35 PM Jerin Jacob Kollanukkaran > > wrote: > >> From: Mattias R=C3=B6nnblom > >>> Performance and statistics improvements for the distributed software > >>> (DSW) event device. > >>> > >>> Mattias R=C3=B6nnblom (8): > >>> event/dsw: reduce latency in low-load situations > >>> event/dsw: reduce max flows to speed up load balancing > >>> event/dsw: extend statistics > >>> event/dsw: improve migration mechanism > >>> event/dsw: avoid migration waves in large systems > >>> event/dsw: remove redundant control ring poll > >>> event/dsw: remove unnecessary read barrier > >>> event/dsw: add port busy cycles xstats > >> Series applied to dpdk-next-eventdev/master. Thanks. > >=20 > > I get a compilation issue on rhel7. > > Too bad the CI did not help. > > https://protect2.fireeye.com/v1/url?k=3D6777ccba-3ba3c0e4-67778c21-8691= 959ed9b7-56149d0a5dee8fea&q=3D1&e=3Dd034618d-5861-42ba-adf3-fc0aafd4892a&u= =3Dhttp%3A%2F%2Fpatchwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D88= 28%26state%3D%2A > > > > > > [1583/1808] Compiling C object > > 'drivers/drivers@@tmp_rte_pmd_dsw_event@sta/event_dsw_dsw_event.c.o'. > > ../drivers/event/dsw/dsw_event.c: In function =E2=80=98dsw_port_conside= r_emigration=E2=80=99: > > ../drivers/event/dsw/dsw_event.c:502:27: warning: =E2=80=98candidate_qf= =E2=80=99 may > > be used uninitialized in this function [-Wmaybe-uninitialized] > > target_qfs[*targets_len] =3D *candidate_qf; > > ^ > > ../drivers/event/dsw/dsw_event.c:445:25: note: =E2=80=98candidate_qf=E2= =80=99 was declared here > > struct dsw_queue_flow *candidate_qf; > > ^ > > In file included from ../lib/librte_eal/x86/include/rte_atomic.h:16:0, > > from ../lib/librte_eal/include/generic/rte_rwlock.h:2= 5, > > from ../lib/librte_eal/x86/include/rte_rwlock.h:12, > > from ../lib/librte_eal/include/rte_fbarray.h:40, > > from ../lib/librte_eal/include/rte_memory.h:25, > > from ../lib/librte_eventdev/rte_event_ring.h:20, > > from ../drivers/event/dsw/dsw_evdev.h:8, > > from ../drivers/event/dsw/dsw_event.c:5: > > ../lib/librte_eal/include/generic/rte_atomic.h:566:22: warning: > > =E2=80=98candidate_flow_load=E2=80=99 may be used uninitialized in this= function > > [-Wmaybe-uninitialized] > > __sync_fetch_and_add(&v->cnt, inc); > > ^ > > ../drivers/event/dsw/dsw_event.c:448:10: note: =E2=80=98candidate_flow_= load=E2=80=99 > > was declared here > > int16_t candidate_flow_load; > > ^ > > ../drivers/event/dsw/dsw_event.c:505:49: warning: =E2=80=98candidate_po= rt_id=E2=80=99 > > may be used uninitialized in this function [-Wmaybe-uninitialized] > > rte_atomic32_add(&dsw->ports[candidate_port_id].immigration_load, > > ^ > > ../drivers/event/dsw/dsw_event.c:446:10: note: =E2=80=98candidate_port_= id=E2=80=99 was > > declared here > > uint8_t candidate_port_id; > > ^ > > >=20 > Looks like a false positive. What GCC version is this? This is with RHEL 7. Please do you have such distro to test and fix the false positive? A quick fix would be very welcome.