From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 03A546A95 for ; Thu, 11 Dec 2014 00:23:52 +0100 (CET) Received: by mail-wg0-f44.google.com with SMTP id b13so4967954wgh.3 for ; Wed, 10 Dec 2014 15:23:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=WEF4yZPQOgkHydfbt012dcbAMiwo0svzpxrTNMsZrdA=; b=hXqnkl5vSyi7C+Xrd6O07kz2v83RJCXNDJ4C3gUo/RUN/jzmXzHhhDUjtEqtuICkcI owd/u1wkJhu6QW0Cdv3SZ3h3mNimESDsdlvKa9RNW5yMjZns5jIGPF+OSU6RMMv5zJg8 Dfts192le5+gRaXbFOLnITGfkMry8MYithBttnpTVsOyw7szfpsJ9jgMTrXRa3vgx9t6 a7F7MTQlpUN/414wXOEhzvXP1nzFUsR3rowPFurUf3S+7pF9Vkk2CKOAljMxM858U0AQ swtbVZDEZgFQF19sYTNNsV51sg7IHrBQ/kaFTWTIatcZtSwJZbiKn7mJGACm8YNsw2OX Xm+g== X-Gm-Message-State: ALoCoQkE6ySl7X+s3OsAuygwLG1NfCbgPpigKT3kafOwUnMWYm6bmsRXTg936gdEfuX9hUSVl3yP X-Received: by 10.194.156.161 with SMTP id wf1mr1420764wjb.134.1418253831832; Wed, 10 Dec 2014 15:23:51 -0800 (PST) Received: from xps13.localnet ([88.249.222.12]) by mx.google.com with ESMTPSA id dm10sm553452wib.18.2014.12.10.15.23.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 15:23:51 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 11 Dec 2014 00:23:24 +0100 Message-ID: <4172805.tCufcf6XqG@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141209083724.1a6872ac@urahara> References: <20141209083724.1a6872ac@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: support X540 VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 23:23:52 -0000 2014-12-09 08:37, Stephen Hemminger: > Add missing setup for X540 MAC type when setting up VF. > Additional check exists in Linux driver but not in DPDK. > > Signed-off-yb: Bill Hong > Signed-off-by: Stephen Hemminger > > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 2014-12-08 09:26:18.150170081 -0800 > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c 2014-12-08 09:26:18.150170081 -0800 > @@ -1911,7 +1911,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_ > /* > * Modification to set VFTDT for virtual function if vf is detected > */ > - if (hw->mac.type == ixgbe_mac_82599_vf) > + if (hw->mac.type == ixgbe_mac_82599_vf || > + hw->mac.type == ixgbe_mac_X540_vf) What about X550? Should it be listed there? > txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx)); > else > txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx)); > @@ -2198,7 +2199,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_ > /* > * Modified to setup VFRDT for Virtual Function > */ > - if (hw->mac.type == ixgbe_mac_82599_vf) { > + if (hw->mac.type == ixgbe_mac_82599_vf || > + hw->mac.type == ixgbe_mac_X540_vf) { > rxq->rdt_reg_addr = > IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx)); > rxq->rdh_reg_addr = It appears to be a fix which is candidate for 1.8.0. Thanks -- Thomas