From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 751701B8A1 for ; Tue, 10 Apr 2018 14:19:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE00621182; Tue, 10 Apr 2018 08:19:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 10 Apr 2018 08:19:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=wnfDXTqS5+7s+jtS9qsel9nLlp GsYK/qTZa8UMIZzFE=; b=f//c+Ay/JntB0VpJG0J/toQqas2XYxzxLs9v1+uQww +J7+orU2I9fSQzprf1dGSJAPt8UhDffSTAqrWWcwH5BeFlc+WXdsm8lPUyzM6Hi7 N5v19sbrsjhbeN9DKIeD20m19Tu9V3bX/kHFopl0yjW7xTP1FEPePwzx1OAA+tCF M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wnfDXT qS5+7s+jtS9qsel9nLlpGsYK/qTZa8UMIZzFE=; b=Mg/JoKahy+YHrmrXmX2HPE LcM8ZPbEp8gmw1NUBrV0LnSUZaxGiEDaUuvjkTNX/orvA5cY7OfGLhODa4TA8dXY MWJS/7cPRYMLk9VAmc2tmmb9RNkbKzSYh5zCO04r12pEWZY/wbzNWxLxqOYwGVq6 aD/yUVo9QTfU2PZcxV4G1UtZ58muJJUTLwWK6mOchgGD8r22DmcORPJXTE3pYzBK rKHcBxU/SxvDdoZINlVGm2VPc8veztXEDArXw3/v66wKcNwnH8UUUI5ClulEl6+s bXOc3Ka/ryfdJu3wNwJ089ZypUypaBF9x69x7EPVUG6y59w7EoLIVt8Wv0kcxVpQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E409E509A; Tue, 10 Apr 2018 08:19:40 -0400 (EDT) From: Thomas Monjalon To: "Singh, Jasvinder" Cc: dev@dpdk.org, "Dumitrescu, Cristian" , bruce.richardson@intel.com Date: Tue, 10 Apr 2018 14:19:38 +0200 Message-ID: <4174344.PR9F3hB2no@xps> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D333361C4@IRSMSX101.ger.corp.intel.com> References: <20180409120632.38567-1-jasvinder.singh@intel.com> <50779258.T1JUn8BQf7@xps> <54CBAA185211B4429112C315DA58FF6D333361C4@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 12:19:41 -0000 10/04/2018 12:25, Singh, Jasvinder: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 10/04/2018 11:51, Jasvinder Singh: > > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > > skip it while building the sample apps on FreeBSD. > > [...] > > > --- a/examples/ip_pipeline/Makefile > > > +++ b/examples/ip_pipeline/Makefile > > > @@ -67,6 +67,13 @@ RTE_TARGET ?= x86_64-native-linuxapp-gcc > > > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > > > > You can use CONFIG_RTE_EXEC_ENV_LINUXAPP > > > > > +$(info This application can only operate in a linuxapp environment, \ > > > +please change the definition of the RTE_TARGET environment variable) > > > +all: > > > +clean: > > > +else > > > > > > Copy of my previous comment: > > " > > It is not skipping the example, just throwing an error (which is needed). > > > > You should add a test in examples/Makefile to really skip it. > > " > > In V2, we follow the same pattern as followed in other examples such as l3fwd-power, ethtool, etc. A kind of counter example is: ifeq ($(CONFIG_RTE_ARCH_X86_64),y) DIRS-y += performance-thread endif But I get your point that it is done this way in several examples. > If we put check in examples/Makefile, than how the situation is handled if someone tries to build ip_pipeline straight instead of building all examples. My thought is that if you try to build explicitly this example on FreeBSD, you should get an error. > > In this v2, you replaced the error by an info message. > > Error was better in my opinion. I will get this v2 and not bother you more about that. All examples could be fixed at once. Not sure it is worth though, given this is the legacy build system.