[dpdk-dev] [PATCH 0/2] Clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

[dpdk-dev] [PATCH 0/2] Clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

[Igor Ryzhov]

The rx_mbuf_alloc_failed counter was only cleared by virtio driver.
Now it is cleared by common rte_eth_stats_clear function for all drivers at once.

Igor Ryzhov (2):
  ethdev: clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset
  virtio: remove unnecessary rx_mbuf_alloc_failed counter clearing

 drivers/net/virtio/virtio_ethdev.c | 2 --
 lib/librte_ether/rte_ethdev.c      | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
2.4.9 (Apple Git-60)

[dpdk-dev] [PATCH 1/2] ethdev: clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

[Igor Ryzhov]

---
 lib/librte_ether/rte_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 3840775..41f5f0b 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1456,6 +1456,7 @@ rte_eth_stats_reset(uint8_t port_id)
 
 	RTE_FUNC_PTR_OR_RET(*dev->dev_ops->stats_reset);
 	(*dev->dev_ops->stats_reset)(dev);
+	dev->data->rx_mbuf_alloc_failed = 0;
 }
 
 /* retrieve ethdev extended statistics */
-- 
2.4.9 (Apple Git-60)

[dpdk-dev] [PATCH 2/2] virtio: remove unnecessary rx_mbuf_alloc_failed counter clearing

[Igor Ryzhov]

This counter is cleared in rte_eth_stats_reset.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
 drivers/net/virtio/virtio_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 74c00ee..f5b72a3 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -788,8 +788,6 @@ virtio_dev_stats_reset(struct rte_eth_dev *dev)
 		rxvq->broadcast = 0;
 		memset(rxvq->size_bins, 0, sizeof(rxvq->size_bins[0]) * 8);
 	}
-
-	dev->data->rx_mbuf_alloc_failed = 0;
 }
 
 static void
-- 
2.4.9 (Apple Git-60)

Re: [dpdk-dev] [PATCH 0/2] Clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset

[Thomas Monjalon]

2015-11-27 13:31, Igor Ryzhov:
> The rx_mbuf_alloc_failed counter was only cleared by virtio driver.
> Now it is cleared by common rte_eth_stats_clear function for all drivers at once.
> 
> Igor Ryzhov (2):
>   ethdev: clear rx_mbuf_alloc_failed counter on rte_eth_stats_reset
>   virtio: remove unnecessary rx_mbuf_alloc_failed counter clearing

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks