From: Thomas Monjalon <thomas@monjalon.net>
To: Tofig Aliev <t.aliev.mnt@gmail.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] raw/ntb: immediate return if no doorbells
Date: Wed, 24 Sep 2025 16:34:55 +0200 [thread overview]
Message-ID: <4185454.vfdyTQepKt@thomas> (raw)
In-Reply-To: <20250731183117.87499-1-t.aliev.mnt@gmail.com>
31/07/2025 20:31, Tofig Aliev:
> Added immediate return from ntb_dev_intr_handler()
> if no doorbells.
Please could you explain the consequence of this bug?
Should it be backported?
[...
> @@ -158,8 +158,10 @@ ntb_dev_intr_handler(void *param)
> }
>
> db_bits = (*hw->ntb_ops->db_read)(dev);
> - if (!db_bits)
> + if (!db_bits) {
> NTB_LOG(ERR, "No doorbells");
> + return;
> + }
>
> /* Doorbell 0 is for peer device ready. */
> if (db_bits & 1) {
prev parent reply other threads:[~2025-09-24 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 18:31 Tofig Aliev
2025-09-24 14:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4185454.vfdyTQepKt@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=t.aliev.mnt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).