DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: pvnnikhilesh@gmail.com, jerinj@marvell.com,
	david.marchand@redhat.com, thomas@monjalon.net,
	bruce.richardson@intel.com, mattias.ronnblom@ericsson.com,
	arybchenko@solarflare.com, declan.doherty@intel.com,
	olivier.matz@6wind.com, nhorman@tuxdriver.com
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] build: makefile make experimental tag as global
Date: Thu, 2 Apr 2020 16:40:06 +0100	[thread overview]
Message-ID: <41857301-bbcc-b188-c7db-e2c958cf009a@intel.com> (raw)
In-Reply-To: <20200402150618.2184-2-pbhagavatula@marvell.com>

On 4/2/2020 4:06 PM, pvnnikhilesh@gmail.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Make ALLOW_EXPERIMENTAL_API global across lib, drivers and apps.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

I am OK to not require this flag for DPDK internally.

But I remember this has been suggested when __rte_experimental implemented but
rejected that time, and forced the flag for internals too.

> @@ -9,7 +9,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
>  LIB = librte_pmd_ionic.a
> 
>  # Required to use rte_eth_dev_create and rte_eth_dev_destroy
> -CFLAGS += -DALLOW_EXPERIMENTAL_API

Some of the flags have comments around them to clarify why the flag is required,
I was mainly requesting it to manange when to remove this flag, those comments
also should be removed.

  reply	other threads:[~2020-04-02 15:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200402150618.2184-1-pbhagavatula@marvell.com>
2020-04-02 15:06 ` pvnnikhilesh
2020-04-02 15:40   ` Ferruh Yigit [this message]
2020-04-02 15:45     ` Pavan Nikhilesh Bhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41857301-bbcc-b188-c7db-e2c958cf009a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=nhorman@tuxdriver.com \
    --cc=olivier.matz@6wind.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pvnnikhilesh@gmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).