* [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test
@ 2018-05-10 1:25 David Hunt
2018-05-10 15:59 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: David Hunt @ 2018-05-10 1:25 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, david.hunt
New warning with gcc 8.1:
When casting the function pointer passed to
rte_eal_remote_launch() as an lcore_function_t *,
it expects the cast function to return an int, but
instead it was returning void. Fixed to return
an int.
Fixes: c3eabff124e6 ("distributor: add unit tests")
Signed-off-by: David Hunt <david.hunt@intel.com>
---
test/test/test_distributor_perf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c
index 557715e13..edf1998ab 100644
--- a/test/test/test_distributor_perf.c
+++ b/test/test/test_distributor_perf.c
@@ -31,7 +31,7 @@ struct worker_stats worker_stats[RTE_MAX_LCORE];
* worker thread used for testing the time to do a round-trip of a cache
* line between two cores and back again
*/
-static void
+static int
flip_bit(volatile uint64_t *arg)
{
uint64_t old_val = 0;
@@ -41,6 +41,7 @@ flip_bit(volatile uint64_t *arg)
old_val = *arg;
*arg = 0;
}
+ return 0;
}
/*
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test
2018-05-10 1:25 [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test David Hunt
@ 2018-05-10 15:59 ` De Lara Guarch, Pablo
2018-05-13 21:04 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-10 15:59 UTC (permalink / raw)
To: Hunt, David, dev; +Cc: Richardson, Bruce, Hunt, David, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 10, 2018 2:26 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test
>
> New warning with gcc 8.1:
> When casting the function pointer passed to
> rte_eal_remote_launch() as an lcore_function_t *, it expects the cast function
> to return an int, but instead it was returning void. Fixed to return an int.
>
> Fixes: c3eabff124e6 ("distributor: add unit tests")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Cc: stable@dpdk.org
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test
2018-05-10 15:59 ` De Lara Guarch, Pablo
@ 2018-05-13 21:04 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-13 21:04 UTC (permalink / raw)
To: Hunt, David; +Cc: dev, De Lara Guarch, Pablo, Richardson, Bruce, stable
> > New warning with gcc 8.1:
> > When casting the function pointer passed to
> > rte_eal_remote_launch() as an lcore_function_t *, it expects the cast function
> > to return an int, but instead it was returning void. Fixed to return an int.
> >
> > Fixes: c3eabff124e6 ("distributor: add unit tests")
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Cc: stable@dpdk.org
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-13 21:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 1:25 [dpdk-dev] [PATCH] test: fix incorrect cast in distributor unit test David Hunt
2018-05-10 15:59 ` De Lara Guarch, Pablo
2018-05-13 21:04 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).