From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EE6952BCE for ; Mon, 22 Apr 2019 14:43:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E13621165; Mon, 22 Apr 2019 08:43:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 08:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=96C0D4edgkLnOzQebBnpqE731n6BpQCkd4MZKS1Igds=; b=qefdlYI1Y6IH 7wLFCJSgbzE8D7YWb8sKiCsGZ1TdE6MfrqX+9hXG55+4dTzRaL5uqcbm8ucZpkx6 Z/TapqlwI3okoZ1nzhaddTeCCDmO65aLI9eRnQ375IBDABR2vAXHP+N1NVLsPiLj 9Kt0uMGaAXUsDVbENHe2VNVC4jWIipM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=96C0D4edgkLnOzQebBnpqE731n6BpQCkd4MZKS1Ig ds=; b=B7x3lCD8hGPrZKAEfO2rFVfqZtE8MN/J04EOSonl7I4mEJ5KDLfuossNQ tc1XWYFGMnMn8JPOisN0fT0Bh9k/AATDYWmGODh+TvZ+BxH4Sf3SzNnDhuhwSYTy xJrsWW4FMSZ7BQw64Vcwq1bPUdHJHzAJeoycXyiPe1YddN9fYSQuVuzdUU26S0pP 3WetTnaRcf0Qtv3INnSlA+garXiYWFevaONMNvv1CZz0tyhuD4mRQyEiycS3/6FJ gf4f/lCZx/gtE6d7qTJbo+bDNyleFgTfQvldfkwDTSyVeFENQObdvXtU/k1XJlR2 2KOalyG3CpNyX1j9WWtBBQr7tzCQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epledtrddvledrudehkedrudehleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F4F0103C9; Mon, 22 Apr 2019 08:43:27 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 22 Apr 2019 14:43:25 +0200 Message-ID: <4187074.1oMGJlaxCV@xps> In-Reply-To: <20190417184506.18850-1-stephen@networkplumber.org> References: <20190417184506.18850-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: fix resource leak on error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 12:43:29 -0000 17/04/2019 20:45, Stephen Hemminger: > If secondary process attempt to mmap the resource resulted in > the wrong address, then it would leave behind the bad mmap. > > Coverity issue: 337675, 337664 > Signed-off-by: Stephen Hemminger Fixes: 2a28a502c607 ("bus/vmbus: map ring in secondary process") Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 62314A05D3 for ; Mon, 22 Apr 2019 14:43:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1035C2C4F; Mon, 22 Apr 2019 14:43:31 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id EE6952BCE for ; Mon, 22 Apr 2019 14:43:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E13621165; Mon, 22 Apr 2019 08:43:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 08:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=96C0D4edgkLnOzQebBnpqE731n6BpQCkd4MZKS1Igds=; b=qefdlYI1Y6IH 7wLFCJSgbzE8D7YWb8sKiCsGZ1TdE6MfrqX+9hXG55+4dTzRaL5uqcbm8ucZpkx6 Z/TapqlwI3okoZ1nzhaddTeCCDmO65aLI9eRnQ375IBDABR2vAXHP+N1NVLsPiLj 9Kt0uMGaAXUsDVbENHe2VNVC4jWIipM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=96C0D4edgkLnOzQebBnpqE731n6BpQCkd4MZKS1Ig ds=; b=B7x3lCD8hGPrZKAEfO2rFVfqZtE8MN/J04EOSonl7I4mEJ5KDLfuossNQ tc1XWYFGMnMn8JPOisN0fT0Bh9k/AATDYWmGODh+TvZ+BxH4Sf3SzNnDhuhwSYTy xJrsWW4FMSZ7BQw64Vcwq1bPUdHJHzAJeoycXyiPe1YddN9fYSQuVuzdUU26S0pP 3WetTnaRcf0Qtv3INnSlA+garXiYWFevaONMNvv1CZz0tyhuD4mRQyEiycS3/6FJ gf4f/lCZx/gtE6d7qTJbo+bDNyleFgTfQvldfkwDTSyVeFENQObdvXtU/k1XJlR2 2KOalyG3CpNyX1j9WWtBBQr7tzCQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epledtrddvledrudehkedrudehleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F4F0103C9; Mon, 22 Apr 2019 08:43:27 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 22 Apr 2019 14:43:25 +0200 Message-ID: <4187074.1oMGJlaxCV@xps> In-Reply-To: <20190417184506.18850-1-stephen@networkplumber.org> References: <20190417184506.18850-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: fix resource leak on error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422124325.YhGVQfm68KcTtUE1HhYV3U4aRUz3l80QORyEGArHn-k@z> 17/04/2019 20:45, Stephen Hemminger: > If secondary process attempt to mmap the resource resulted in > the wrong address, then it would leave behind the bad mmap. > > Coverity issue: 337675, 337664 > Signed-off-by: Stephen Hemminger Fixes: 2a28a502c607 ("bus/vmbus: map ring in secondary process") Applied, thanks