From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 931DDA00C2; Thu, 8 Dec 2022 14:22:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 723BE40E28; Thu, 8 Dec 2022 14:22:22 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2C5F840A7E; Thu, 8 Dec 2022 14:22:21 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6218B5C00D6; Thu, 8 Dec 2022 08:22:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 08 Dec 2022 08:22:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670505740; x= 1670592140; bh=oAoP/eZcls/Dy6GNWerPCGlgsLwWZnbLyviDyuCBuUQ=; b=b xJStwq3zzDJEbGb8C5FbqkPOiYqFPZ6a7fXcvH9cNwgSv9xcrZOtMsj6jjZiWJuv G1Bj2tLHbfrdj1Na8gMe3Iv61BrkYdrsfZQ2MULOCASgUKYzNopM/sAinjQYh+An ayS6tyCBkeDiM9keeXaw+9sEjoDlgEgs4rWEpXFV9RL4kfstqCdlpeRfK1P3X6+N JHNPVNi/Medrz4UAZIVri8xDnewfnaqumKT8cu6Quclw6QQiy/NrnRwGjGYTA2l7 FqpWljCdGpx5q/KgqNYkuJexNzY6TeA+Wj3MOU6IUi4LDO2Wwg3epPipyDEMEbce QLQIDMl6aHNnWE1y6PdAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670505740; x= 1670592140; bh=oAoP/eZcls/Dy6GNWerPCGlgsLwWZnbLyviDyuCBuUQ=; b=b rL+yHtObnJpyVECu7BEXO8MhI0ZpQ1Pb6euOndIobvtY6+scwuv0zKw2WhgFTohS Rwf9qKz0PjI5IwCuiMuBxmkqyiYBMjV7i/6+NiLC2BFQ9if5In15BjSFnlxDJn6Y qwW9Srldg86Bdo6QQeoUo761GFJ2MdvGipAi4OpykiIFu4Egb7vWx0M2qeGD/g9F Z0zHdVw745ohs+UvbxTIqae2zw6jWyleS/NwthY1V3IgrV2dNV7mrGi53uBGVDSI rvLd9s0webJ1mfxANMixpU5Da3xpbNX2W70m0AkZIZa4nkV24DQUmLALPttuZE06 eA56z+Z7a9+6r+5rDEoHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleffteeh veduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 08:22:17 -0500 (EST) From: Thomas Monjalon To: Patrick Robb Cc: Ferruh Yigit , David Marchand , Akhil Goyal , "ci@dpdk.org" , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" , "dev@dpdk.org" , "stable@dpdk.org" , Bruce Richardson , Michael Santana , Abdullah =?ISO-8859-1?Q?=D6mer_Yama=E7?= , Aaron Conole Subject: Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted Date: Thu, 08 Dec 2022 14:22:15 +0100 Message-ID: <4188342.mogB4TqSGs@thomas> In-Reply-To: References: <20221129140032.35940-1-david.marchand@redhat.com> <16994d83-8f31-1ee6-94b5-abfefb8566fb@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I'm sorry Patrick that it gives you more work. Your proposals below don't look possible because a tag is something fixed forever. We had an ABI issue in the initial tag so we cannot use the tag v22.11 as planned. I don't see how we can better plan except having more tests on release candidates. 07/12/2022 19:00, Patrick Robb: > Hello, > > Community Lab team members are wondering whether it is possible to bump > v22.11 to include at least this patch. We have an existing codebase which > relies on a vXX.XX scheme for producing ABI references. We parse that out > at different places in our code, so fixing this to handle vXX.XX.X will > require some changes on our end. We can do that, but it puts the timeline > on turning on ABI testing at the community lab back some. A v22.11 tagged > release with this patch would allow for us to turn on ABI testing > immediately. There was also a suggestion that having the "base" tag (like > the simple v22.11) point to the latest revision is a more standard version > naming approach and may be more intuitive than what is being used currently. > > If that is not possible, we will update our code to be able to refer to a > vXX.XX.X tag for producing the ABI reference. If we adopt this approach, we > would like to request that with future releases, a "vXX.XX.0" tag could > always be made available for us to produce ABI references from. That way, > we can prepare for turning on ABI testing knowing beforehand the tag name > we will be using. > > On Tue, Dec 6, 2022 at 7:25 AM Ferruh Yigit wrote: > > > On 12/6/2022 10:18 AM, David Marchand wrote: > > > On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit > > wrote: > > >> On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > > >>> 05/12/2022 14:47, Akhil Goyal: > > >>>> But adding a tag on same repo is more convenient from developer point > > of view. > > >>>> However, it is my personal view, others may differ. > > >>> > > >>> From developer point of view, you should use > > devtools/test-meson-builds.sh > > >>> which does the "git clone" for you. > > >>> > > >>> This is what I have in ~/.config/dpdk/devel.config > > >>> export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref > > >>> export DPDK_ABI_REF_VERSION=v22.11.1 > > >>> > > >> > > >> Does it help to update 'test-meson-builds.sh' to use an environment > > >> variable to select which repo to clone? > > >> If so, I can send a patch for it. > > > > > > I was wondering too... > > > I would expect most maintainers have the stable repo in their config > > > but it would not hurt to handle the case when they don't for others. > > > > > > +1 > > > > Sent following if it helps: > > https://patches.dpdk.org/project/dpdk/list/?series=26015