From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7781745D48; Wed, 20 Nov 2024 00:09:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E6E240288; Wed, 20 Nov 2024 00:09:18 +0100 (CET) Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) by mails.dpdk.org (Postfix) with ESMTP id E8DF64025D for ; Wed, 20 Nov 2024 00:09:15 +0100 (CET) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7D13511401E3; Tue, 19 Nov 2024 18:09:15 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 19 Nov 2024 18:09:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1732057755; x=1732144155; bh=Iapwe6UiC7EtLJ40c4hoQXWo8LyXqcUpNwdhcq7iLqI=; b= FlT0CMr0KlEOmvvKfX3otR8We+tJU3FRpFIFSHBLY60nF2Fbwsl32kPkHkEydcz0 xPdkniZcCT9rOhNasx2+9319Ta0QJeJoZDCsYjKehMc/21d0lsLZ0joOvR1OoU8O ZQjEoUs4ixzydxTw1uMJ/lK2871zylLJqHPiMLhwjvpnj48bzWAwom/AwAB1ZAoz TK65l5y0g9d5nrbDAB3h7VIiuFqAfLvsBD5HnG7a4lpG3jLA5liae3ykZ82tUrCL i+/T3aDQXFC+qS88wAhljZp4v/yCXTDx1Y8vphUFH/47M5h9rKkiEP2m7PvBA8c9 HzfsynMBCbOsJNYQ3cjnkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1732057755; x= 1732144155; bh=Iapwe6UiC7EtLJ40c4hoQXWo8LyXqcUpNwdhcq7iLqI=; b=V HylEPG9TLE7WP7q4tZFgOxXfrQKZaOqoBxnAag7PCGsRXzezYAxYT5BcDLE6Xnx+ icT9UO+8BvJ7SylqThZA0DXZPR9/IbsGCMnJ2oktUNkDOQ2jRU4ClYN7aPbksm1D b8UMnF2E/FaiuvBmziP+8PCpEraXJ2NyppFygpPGbJnnJYM+8ZztP47/1s6UgK9b ApWBABaex40RJSatASkJkTZdsBmYR/Q+XXwF6Ptlve3UgObPMUPdRI25PlXrsMoC n78nBmzP4cvNpNFVCqHuRZ6zAdmiP+Lfw6dMFdQ2imv7xPANvzbK8uwsv+CLpN1F 0RLfQw2kvCs0dgHovKbqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfeefgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepughmihhtrh ihrdhkohiilhhiuhhksehgmhgrihhlrdgtohhmpdhrtghpthhtohepsghruhgtvgdrrhhi tghhrghrughsohhnsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrd horhhgpdhrtghpthhtoheplhgvfiesphgvrhhfthgvtghhrdgtohhmpdhrtghpthhtohep rghnrghtohhlhidrsghurhgrkhhovhesihhnthgvlhdrtghomhdprhgtphhtthhopehsth gvphhhvghnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopehmsges shhmrghrthhshhgrrhgvshihshhtvghmshdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Nov 2024 18:09:13 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Bruce Richardson , dev@dpdk.org, Lewis Donzis , dev , Anatoly Burakov , Stephen Hemminger , Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Date: Wed, 20 Nov 2024 00:09:10 +0100 Message-ID: <4188729.6PsWsQAL7t@thomas> In-Reply-To: <20241119212703.0dc6c9b0@sovereign> References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241119212703.0dc6c9b0@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/11/2024 19:27, Dmitry Kozlyuk: > 2024-11-19 15:48 (UTC+0000), Bruce Richardson: > > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > > Is the extra control necessary, i.e., why not just always do this and let > > > > the EAL option control whether the pages get dumped? > > > > > > I've been evaluating your suggestion and see no downsides, > > > except contigmem default behavior change, but does it have non-DPDK users? > > > If no one objects, I'll prepare v3 doing the following: > > > 1) everything from v2, > > > 2) except always mark contigmem buffers as dumpable, > > > 3) add --dump-mapped back and make DPDK disable dumping by default. > > > As a result, in order to include mapped memory in coredump: > > > * FreeBSD will require only "--dump-mapped"; > > > * Linux will require both "coredump_filter" setup and "--dump-mapped". > > > > That all seems very reasonable, but it is late in the release cycle at this > > point. Do you think it would be good to just take the v2 as is for 24.11, > > and then change things thereafter to have more dynamic/runtime control of > > the dump-setting in 25.03? > > > > From compatibility viewpoint, I don't think there are any non-DPDK users, > > so if behaviour with EAL doesn't change, I don't think having the kernel > > module default be different matters as we go from one release to the next. > > If you think it is worth adding to 24.11, then by all means. > V2 works as intended and it solves Lewis' problem. > I wasn't rushing with v3 just because I knew that > new EAL options can only target 25.03 since 24.11 RC was out already. Applied, thanks.