From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D78AFA0561; Sun, 19 Apr 2020 15:09:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8AF61D618; Sun, 19 Apr 2020 15:09:16 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 847891D60D for ; Sun, 19 Apr 2020 15:09:14 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3CED96B5; Sun, 19 Apr 2020 09:09:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 19 Apr 2020 09:09:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FrEUAMpbDFjR86X9Inm+AGbg9vrKAfHjmhMwTe4nJLE=; b=Rz191uvVgaN2ekPL iFtVrMktkUZrKrrpETlj3SGsIIjjfAR/GmTiU40CK7IWfqNzbhKwwRHyjBv58RN3 x8MRwyCBntxsGRI61QODGA700UbAWvSdTUc+YJj1Fd69LPUFfdgW6tls6VbUmHcj 6kar8vOyjN+4ViiUD6thvbRzct2mMMMRcWiq0Cgzi9QkfX7hPOSYcJh9r+7UIbAK JdxbDYvlqgtoSGuSVyjr5PhS9fqlNEdtFhmg+/6mDHiWNk0w3PjncaDl/80uPtQg 7YbljJwlnAFRnOVFlssmDHftOUfLH1XHE/U9yoGOAVHFaAXTNfwAsrWWhHA/myGZ 7nItuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FrEUAMpbDFjR86X9Inm+AGbg9vrKAfHjmhMwTe4nJ LE=; b=uCWZa4xQ6O295KAHwTjnFjgzDVAEFgSxMVz9Fs29Qh9fBugBxkxJNxT16 BPigYrkYlVIeKPp7+PEPz5YHFZqOk+tiDcOpIBKqVSGW28WRQbAud965Y/+41O5r bM0zabhzoQqS/sjYstNxDIgt7bBg8jweU8jHd5C2QvEVuKPk3eKJAvE/FkEp/Z6J s2vt2f3d5RuyMVUT2C057rWrgVOJqIlNzuOjg8ujR+xia6qlmFCYhpmMM8Mu+o6b BHK/2s0YOEHDPAvMwUX/QfZVLIwC5SA5mVUBSXqSLUSPwXBXQzr5A94BDL8T9LfP l8O4kPi7JML9mADQWMawIofRX7PIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgedugdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9727E328005A; Sun, 19 Apr 2020 09:09:10 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: Tal Shnaiderman , dev@dpdk.org, dev@dpdk.org Date: Sun, 19 Apr 2020 15:09:09 +0200 Message-ID: <4193388.A7TYtsqqnE@thomas> In-Reply-To: <651f25bd-29e2-2058-70e8-59829e0b53bb@intel.com> References: <7970b43f-dd45-49de-9081-f2903af20635@intel.com> <651f25bd-29e2-2058-70e8-59829e0b53bb@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/04/2020 16:09, Burakov, Anatoly: > On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: > > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: > >> Hi Anatoly, > >> > >> I=E2=80=99m working on the implementation of bus/pci driver for Window= s,=20 > >> pci_common.c uses the titled functions however they are relevant only= =20 > >> for Linux OS. > >> > >> I=E2=80=99m wondering if the implementation of those functions should = be moved=20 > >> to a Linux specific area since FreeBSD (and now Windows) are forced to= =20 > >> implemented those in the current state. >=20 > Unfortunately, we don't have a generic API for these, but since we=20 > export a single API on all platforms, either all platforms have to=20 > implement these functions, or none of them do. There's simply no way to=20 > avoid implementing stubs for these functions, short of coming up with a=20 > generic API that would replace these. Given that this API is heavily=20 > Linux specific, i don't see that happening. Because it is Linux specific, we should not force FreeBSD and Windows having stubs. Can we move VFIO calls in Linux-specific files? I think rte_vfio.h should be moved in lib/librte_eal/linux/include.