From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 0E1252142 for ; Thu, 28 Jul 2016 20:28:59 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id o80so120325305wme.1 for ; Thu, 28 Jul 2016 11:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=tHMftD33kJBrqwd54NQxPQ4jLkAz+Z7Kjip/Fd/zjF8=; b=QVIKa8TBbG13L6c/Dvwzo3/4qEWGAqMEtikCUEvsnhmgcgQM+uYAfjVUJzCXnv4DKF +/NygYunBOovXsApI0V2lQ1Z/zPXdQ6NxY4nFSQxfBLasCJsd1s1f2oV3XmtKHrWGqz1 WqbZclQJyAa5SLjtTRkcxqt3sXa4o3N7R5LTiZdaVL2tmJB3rdL3PowgZzJN011c/re4 Ffo+feR1oo/2D+hBuzNPwKAaSx6ulz2RV+802+/0buCiiqUEN4kCRZm0oB4ByRfm7nQj u82hxA7YSBRVviX7dB3jGdy8eBNHZ5/O3EEHuCq5RddQcP/TfBlrsFd+0MfxDElOUwnU veQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=tHMftD33kJBrqwd54NQxPQ4jLkAz+Z7Kjip/Fd/zjF8=; b=WMD0YgrSKUn1DUM37vbkMy7ALuy+W7Oft6Z+ak3n8+tzgnAxQc6kAS6nDwaYKoh6iR 46aGSmU3fxDuPQruU1IyKAJrxfan49BESBvwqua1Lek0VdWd0CrntJGMg/bo778Afyyr UNyBf7/BrKbY7AE0XbyGluUR02f2abdv7uQspdEwntwssaQwtaPcEyfAW06uC9GbPtTM g2dN5VBy7BvgO1tbejt1alc4g0510RpHFSImOTyoZ/mXN2eVke896QdbWQ3TWANMz8g1 euiQcczpIR9SReMoPtJEi0JbOUxNlzSiPW3xHb7prTj2B/hovsHUyLFw8MbAKtEHCkLc HL2w== X-Gm-Message-State: AEkooutxNbJ0sB+l8//YFcx88v2jGtZqZOoQyohLD7uXUB0/0CW9r8FDu6qBQBY/HsVcS3Vq X-Received: by 10.195.11.104 with SMTP id eh8mr34895277wjd.128.1469730538748; Thu, 28 Jul 2016 11:28:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h7sm12720332wjd.17.2016.07.28.11.28.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2016 11:28:58 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Roy Fan" Cc: "Dumitrescu, Cristian" , dev@dpdk.org, Panu Matilainen , "Singh, Jasvinder" Date: Thu, 28 Jul 2016 20:28:57 +0200 Message-ID: <41993039.3oY5XAlVDj@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <7134797.PeUvHm5xl4@xps13> References: <1463404710-25146-1-git-send-email-roy.fan.zhang@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912647A3BBB9@IRSMSX108.ger.corp.intel.com> <7134797.PeUvHm5xl4@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct rte_port_source_params and rte_port_sink_params X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 18:28:59 -0000 2016-07-27 12:42, Thomas Monjalon: > 2016-07-27 10:08, Dumitrescu, Cristian: > > As Thomas mentioned, today is probably the last day to discuss ABI changes. This one is pretty small and straightforward, any issues with it? > > > > Panu had a concern that the change from "char *" to "const char *" is too small to be regarded as ABI breakage and we should simply go ahead and do it. My conservative proposal was to put a notice anyway. > > > > Nonetheless, what I would like to get from Thomas and Panu is a path forward for this now: > > a) If we agree to consider this an ABI change, please merge the notice for 16.7; > > Panu was noticing 3 things (and I agree with them): > - it is an API change > - they can be grouped in only one list item > - it is better to wait having more changes to break an API > > About the third point, in this specific case, I think it is acceptable because: > - it should not break the ABI > - the impact of the API change is really small > - I'm not sure the packet framework should be considered as a DPDK API. > > > b) If we agree this is too small for an ABI change, please let us agree now > > to accept our quick patch for 16.11 for this change. > > For an API deprecation notice (reworded), > Acked-by: Thomas Monjalon Applied, thanks