From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id DCFB21B2B2
for <dev@dpdk.org>; Tue, 13 Feb 2018 22:21:42 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 6C90721477;
Tue, 13 Feb 2018 16:21:42 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Tue, 13 Feb 2018 16:21:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=B0aMezzUWMH1PFAZsXjGfG2LQQ
0dnl2yvzCfxJIko2k=; b=otgqiPkNQJ61RVENvTMln3ssQLCZ3GLQNNTPpw8zLQ
461m4jBYvMXBh28X3kTDEjIpwKX7otcNFB7YJBzWD23WxLMWhjdnPZq0laWkX3XM
2ljiGGUiahnxbQz21zi+q73Bbvz4ufCMXE2T4mOqGXlbj/DlqyyTKGRDTS2AXKhN
s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=B0aMez
zUWMH1PFAZsXjGfG2LQQ0dnl2yvzCfxJIko2k=; b=Qxa3+SLeHzs1LlQgC5ior8
RscGyx6ke4nB9/3Y1Na6Ou828jZVPwYT+Tql+71gvSTToQSj5jJYz0RA4vLQeOeM
eZmhfy0B8pvsTDsBDQDuJQp9RhrjD6aIBtAhHCutE/7Ur5qv4YIWI18B/eNM8WX1
Q4yzL6d9bahySY+9Ueu6pg9YlkBV2/Vxct4ro/GJ++l8pk7+u9p8sJ8Tg+cvCmh7
D9dQqaQCoNu2xqXdFgPKRkalc8vOCy5ZTcSAqIRtZ/dJl8+Yfby0tlW8gyw30DD/
tuPbS5qpI+iBKAQ9yWWIY8/hmX7PEQa0Mi2Nq50iZSw9jocVhOEqewIzIKVj9Lwg
==
X-ME-Sender: <xms:5laDWnFPc2noIuWobIt34pdxmU_4BM2rDQ6cN9_0Sv9bjFoV48Hg0Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 1ED207E4E9;
Tue, 13 Feb 2018 16:21:42 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
=?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Date: Tue, 13 Feb 2018 22:21:32 +0100
Message-ID: <4199780.l4afLUpUQf@xps>
In-Reply-To: <AM4PR0501MB2657CF518AF48B15F1AAF0A9D2F60@AM4PR0501MB2657.eurprd05.prod.outlook.com>
References: <1518369872-12324-1-git-send-email-matan@mellanox.com>
<E115CCD9D858EF4F90C690B0DCB4D8976CC98BE2@IRSMSX108.ger.corp.intel.com>
<AM4PR0501MB2657CF518AF48B15F1AAF0A9D2F60@AM4PR0501MB2657.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2018 21:21:43 -0000
13/02/2018 22:13, Matan Azrad:
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> > There is a compilation error due to this patch on FreeBSD:
> >
> > drivers/net/failsafe/failsafe_private.h:377:53: error: format specifies type
> > 'unsigned long' but the argument has type 'pthread_t' (aka 'struct pthread *')
> > [-Werror,-Wformat]
> > DEBUG("Hot-plug mutex was locked by thread %lu%s", pthread_self(),
> >
> >
> > I am not sure how to print a pthread_t, so I can just report the issue.
> >
> Can you check with (unsigned long int) conversion?
On FreeBSD, pthread_t is:
typedef struct pthread *pthread_t;
pthread_t is not portable and should not be printed.
I am preparing a patch to enable pthread_t debugging only in Linux.