From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C75BA046B for ; Fri, 23 Aug 2019 12:00:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EDE91BFA1; Fri, 23 Aug 2019 12:00:48 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 82B7E1BF69 for ; Fri, 23 Aug 2019 12:00:46 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BA3FE280069; Fri, 23 Aug 2019 10:00:44 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 23 Aug 2019 11:00:37 +0100 To: , , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Adrien Mazarguil CC: References: <20190821204755.1990-1-pbhagavatula@marvell.com> <20190821204755.1990-4-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <419dfbc4-24ac-f4dd-584e-e2e842fda898@solarflare.com> Date: Fri, 23 Aug 2019 13:00:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821204755.1990-4-pbhagavatula@marvell.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24864.003 X-TM-AS-Result: No-8.126200-8.000000-10 X-TMASE-MatchedRID: vbSD0OnL8/Ieimh1YYHcKPZvT2zYoYOwC/ExpXrHizyRoQLwUmtovzCW p18HPoW8SjVIFO5E44A8Lz/SCMJ/sjTHlbL9ZrD9IAjxomarSPDxuhkRWK22GJ+4ziUPq4Lxn4W pOLqmK8jnUZFgetPxf1VE1ArpqlmLxHzEqYDYHvstuNep3N20JTsY2/UEG7fk7VWmYaIPG1xAHO g8qEtqyAjN8Ql23yICw1CSKv+bYtq0Nx5/0yISyWOILin78AgWyeUl7aCTy8jDra5IbmQvVubHP yOr12Pd/ZINqUTML/ThhLoXIby/KBWVVkGuW6JrIj0zFI5DoJKCQxfA+iO7F6zG9MIKeG/GP9Gk 1ESLw5jOH38lNbOoTO0kh8+z6oXjl2U0xIbdl0wNEGOVZ0MgDcdtmwbxPlmOOyxd6V963VS48Wu RFQVdauLzNWBegCW2RYvisGWbbS+3sNbcHjySQau+08oqCcwYG2TQ8exEjpY4df3eRCgt5wVQpc 9fCW+D+i7g/Sb1aioLBDB0vQUA/PZEEVvLtrlX4pz7xQr59CJqg4DmmNGMTyR8a9cmnki82eUpB ujbOsFHUAKCz27Vz3Ches9ywUyp1UpKQiKt7fuyeg+lA4WxMG7Zw9m/tEsp1sO0vPiGApH+Zbd1 uQWTtgHii3a3gRUpwL6SxPpr1/I= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.126200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24864.003 X-MDID: 1566554445-3TypKkybrru6 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/7] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/21/19 11:47 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to > enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and > `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and > `RTE_FLOW_ACTION_FLAG` are enabled. > > PMDs notify the validity of `rte_mbuf::hash:fdir::hi` to the applcation > by enabling `PKT_RX_FDIR_ID` flag in `rte_mbuf::ol_flags`. > > Signed-off-by: Pavan Nikhilesh LGTM, few minor notes below, otherwise Reviewed-by: Andrew Rybchenko However, it is a long discussion of it in v1 which should be taken into account. > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index b66bf1495..5d9d88d76 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1316,7 +1316,8 @@ enum rte_flow_action_type { > > /** > * Attaches an integer value to packets and sets PKT_RX_FDIR and > - * PKT_RX_FDIR_ID mbuf flags. > + * PKT_RX_FDIR_ID mbuf flags when > + * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is set. I'd not concentrate on rx_mode offloads here. I'd say: when Rx offload DEV_RX_OFFLOAD_FLOW_MARK is enabled. > * > * See struct rte_flow_action_mark. > */ > @@ -1324,7 +1325,8 @@ enum rte_flow_action_type { > > /** > * Flags packets. Similar to MARK without a specific value; only > - * sets the PKT_RX_FDIR mbuf flag. > + * sets the PKT_RX_FDIR mbuf flag when > + * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is set Same as above. > * > * No associated configuration structure. > */