From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6D43A04B5; Wed, 30 Sep 2020 18:26:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC2291D58D; Wed, 30 Sep 2020 18:26:04 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 736F01D58A for ; Wed, 30 Sep 2020 18:26:01 +0200 (CEST) IronPort-SDR: 5ReFkkQD8cQWm93O1xp2xLScuL2qdtUZbA7Pf/WE/uB0dLg7W6UnEoLd+pdgQP/PmuH3Rp1dtA ED0YiQU5iDzw== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="180646607" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="180646607" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 09:25:58 -0700 IronPort-SDR: +6Bt2YtFGYxakp99FeQbClccqpILgxsqpDPnPtVYjn7x0Lboa9DVWClbratSkMCbN3S8OC8saM eI8EgOdDNeYA== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312643760" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 09:25:56 -0700 To: SteveX Yang , dev@dpdk.org, Bruce Richardson Cc: bruce.richardson@intel.com, wenzhuo.lu@intel.com, beilei.xing@intel.com, qiming.yang@intel.com References: <20200910022018.8955-1-stevex.yang@intel.com> <20200915020836.18396-1-stevex.yang@intel.com> From: Ferruh Yigit Message-ID: <41a7a830-ae0b-7f46-5ad8-aa5d38219578@intel.com> Date: Wed, 30 Sep 2020 17:25:53 +0100 MIME-Version: 1.0 In-Reply-To: <20200915020836.18396-1-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when used latency stats lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2020 3:08 AM, SteveX Yang wrote: > meson build cannot find the header rte_latencystats.h when build DPDK > first time or never installed DPDK lib after build via meson/ninja. > > Because the corresponding header directory isn't included after enabled > RTE_LIBRTE_LATENCY_STATS flag. > > Add the lib 'latencystats' to deps of meson.build of test-pmd, the > corresponding header files will be included automatically. > > Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation") > > Signed-off-by: SteveX Yang > --- > v2: > removed long cflags and added 'latencystats' as a dependency of testpmd The code has 'RTE_LIBRTE_LATENCY_STATS' which needs to be updated. But I see Bruce is working on a more generic solution: https://patches.dpdk.org/project/dpdk/list/?series=12283 I will mark this one as superseded and will wait the Bruce's set for fix.