From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A880DA00C5; Thu, 15 Sep 2022 13:33:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87B064021D; Thu, 15 Sep 2022 13:33:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1CBFA40156 for ; Thu, 15 Sep 2022 13:33:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663241597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gp+i85Sb4eh4tkQz5AJYwDJULfoZ8N2Mjf0OcjEDVn4=; b=hxj8SyPLsA6GtKP7V0es5HWMQoAl0uHRfh3tDdRtUR2A5pVDVpGnJdMji8YhKKMOYwnPQV 0aZwtTLM3F9jnGP4axIyDBcAVPEZQ+uqNV96Zvy6TyCBdS/LaG7fSh9PhJHZSIuWU0tEHx pH1Mt0SLEpv9Qym/er0b8SOiA/IKIJc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-13-SFwDsvN8OsC9x1eyr3JYeg-1; Thu, 15 Sep 2022 07:33:14 -0400 X-MC-Unique: SFwDsvN8OsC9x1eyr3JYeg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34A8D185A7A8; Thu, 15 Sep 2022 11:33:14 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 024AB10EB8; Thu, 15 Sep 2022 11:33:12 +0000 (UTC) Message-ID: <41b23de6-f88f-ce17-5d96-9b4f28dfbec3@redhat.com> Date: Thu, 15 Sep 2022 13:33:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 35/37] baseband/acc100: add protection for NULL HARQ input To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-36-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-36-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > It is possible to cause an invalid HW operation in case the user > provides the BBDEV API and HARQ operation with input enabled and zero Not sure, but s/and/a/? This is again a fix, and should be tagged appropriately. > input. Adding protection for that case. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 461ebe67cd..be4c1d07ed 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1457,6 +1457,14 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, > op->ldpc_dec.tb_params.ea : > op->ldpc_dec.tb_params.eb; > > + if (unlikely(check_bit(op->ldpc_dec.op_flags, > + RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE) && > + (op->ldpc_dec.harq_combined_input.length == 0))) { > + rte_bbdev_log(WARNING, "Null HARQ input size provided"); > + /* Disable HARQ input in that case to carry forward */ > + op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE; > + } > + > fcw->hcin_en = check_bit(op->ldpc_dec.op_flags, > RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE); > fcw->hcout_en = check_bit(op->ldpc_dec.op_flags,