From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61892A04B5; Mon, 16 Nov 2020 17:27:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06EAA323E; Mon, 16 Nov 2020 17:27:25 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E54BE2C16 for ; Mon, 16 Nov 2020 17:27:22 +0100 (CET) IronPort-SDR: DhLjmGMfjLCknbAkRVhqkWlLWZuZp/ZWYF+e7hHW3tLAVFslOYWXHqLSkiXGb8aVhc32culq9u gw9EseXmKwFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="170942403" X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="170942403" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 08:27:21 -0800 IronPort-SDR: ueFIlDYSy+bhH3krkkS/I2viBQIT1DTuuWx+tXIf1W+tALjhcOKD/Ump39SGqL3zd6z5uo9LHR AI4IUNhKB2xQ== X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="475579106" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.57]) ([10.213.227.57]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 08:27:20 -0800 To: Xiaoyu Min , Jasvinder Singh , Cristian Dumitrescu Cc: dev@dpdk.org, Dekel Peled References: <0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com> From: Ferruh Yigit Message-ID: <41f0fbac-59e5-bddb-3e4d-744da727bd7c@intel.com> Date: Mon, 16 Nov 2020 16:27:19 +0000 MIME-Version: 1.0 In-Reply-To: <0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/16/2020 7:55 AM, Xiaoyu Min wrote: > From: Dekel Peled > > The rte_flow_item_eth and rte_flow_item_vlan items were updated in [1]. > The rte_flow_item_ipv6 item was updated in [2]. > The structs now contain additional metadata following the header data. > The size to use for match should be the header data size only, and > not the size of the whole struct. > > This patch replaces the rte_flow_item_* with the corresponding rte_*_hdr. > > [1]:commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN > items") > > [2]: commit ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item") > > Signed-off-by: Dekel Peled > --- > drivers/net/softnic/rte_eth_softnic_flow.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers/net/softnic/rte_eth_softnic_flow.c > index f05ff092fa..7925bad1c0 100644 > --- a/drivers/net/softnic/rte_eth_softnic_flow.c > +++ b/drivers/net/softnic/rte_eth_softnic_flow.c > @@ -169,22 +169,22 @@ flow_item_is_proto(enum rte_flow_item_type type, > > case RTE_FLOW_ITEM_TYPE_ETH: > *mask = &rte_flow_item_eth_mask; > - *size = sizeof(struct rte_flow_item_eth); > + *size = sizeof(struct rte_ether_hdr); > return 1; /* TRUE */ > > case RTE_FLOW_ITEM_TYPE_VLAN: > *mask = &rte_flow_item_vlan_mask; > - *size = sizeof(struct rte_flow_item_vlan); > + *size = sizeof(struct rte_vlan_hdr); > return 1; > > case RTE_FLOW_ITEM_TYPE_IPV4: > *mask = &rte_flow_item_ipv4_mask; > - *size = sizeof(struct rte_flow_item_ipv4); > + *size = sizeof(struct rte_ipv4_hdr); > return 1; > > case RTE_FLOW_ITEM_TYPE_IPV6: > *mask = &rte_flow_item_ipv6_mask; > - *size = sizeof(struct rte_flow_item_ipv6); > + *size = sizeof(struct rte_ipv6_hdr); > return 1; > As far as I can see the 'flow_item_is_proto' sets the size to be used over 'rte_flow_item_*" types, the original values seems correct to me, am I missing something. Can you please elaborate why the change is needed?