From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFB2642661; Thu, 28 Sep 2023 14:51:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF60140273; Thu, 28 Sep 2023 14:51:19 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2084.outbound.protection.outlook.com [40.107.94.84]) by mails.dpdk.org (Postfix) with ESMTP id 1ED3B4021D for ; Thu, 28 Sep 2023 14:51:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaSFVwGdEv4njTafzZkKBUKLMrQcJdRCyka/URc+s0eovB7eXhTltBl+lnLe/R5BBpINsRs/JWyx7LUbhvOxy4A07Yc7mEf9ZPQvjV4ToQe4MA5d2jwL11WwD3KpCYCwGG/3N8HBjTieYfsX2ElhI06u6eTevjWbSQ/f43xNqr6xKv0AIdyKO18UJaWYrZfWutEJcOOzo2MgikTMw9EJIDkPNEePAZPGBKra+oE2oIGT5GY8R6M67/DO9mm/Qvu6Jllru/8FXYocIKBm7/iYEiBFVM5sZF31TODehtV6lzJA+KDhdTOkmvRFZz1+lhxeGAAovv0FYhJsz9QLHwRQEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xCAh969+HQ5fiZETy4jMKcHSLqCIxoSoDKhy0ktKNUA=; b=DHAIKG46yRzfJSTPlPihdxpKVZOGHgtRP/hCFl/UjI82YUrDW0TLPK5exucy2ywCdFmr8cZfg62isOdxhiOc430GxWGeqc8tO0VzimUFBwfKyg2KtnQLgBUaNvmspI3QIcB2JGgMpPCahl+xYBAxsLOufAzG3IxuqnSRie6n6dGMBgMcnqk5hILZgd44DjDUe1cBumJEPqQ0HPhBYH00vq5oS808JUt0IxH5gADzpVAS0AaO2ABTpjv8ocfCDbGReY0cYQ0ZZYX6NgWiDSzX6kNb1oGqwGShYewbn2pKYubkJJUM7T3eJ4De9ziDLKhF3kLsio9A5DPOQy0fx6x7bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xCAh969+HQ5fiZETy4jMKcHSLqCIxoSoDKhy0ktKNUA=; b=lcxdiI+wgOW8tJvMVGyfqFk9d7e0i+Trd4+9I6FIJBdTyZ0F0ZnxeqEWWlaPR3Jo/smclVw8cbfdHFtY2h79W5JwUHlakSLetWNfz5erdheWS4/ewL9b7J8/5agwwvCgQKedBjzu8FVKNEqjN6YCubF7GGk/BJjhKhHRY8wSCJs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6604.namprd12.prod.outlook.com (2603:10b6:208:3a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22; Thu, 28 Sep 2023 12:51:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Thu, 28 Sep 2023 12:51:14 +0000 Message-ID: <41fba429-98c5-4332-b7a3-1da98aacca50@amd.com> Date: Thu, 28 Sep 2023 13:51:08 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/36] fix Rx and Tx queue state Content-Language: en-US To: David Marchand , Jie Hai Cc: dev@dpdk.org, lihuisong@huawei.com, Thomas Monjalon References: <20230908112901.1169869-1-haijie1@huawei.com> <6c030892-5e27-4537-9262-c733914d95df@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0149.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6604:EE_ X-MS-Office365-Filtering-Correlation-Id: f3e1eb28-2231-47f7-3fec-08dbc0219993 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XsHAPfpUCjhSyuBvTzqroILaFeMft97YbKiTFAN3yuwwp91cRriXVs/w6MQeBKooj6QlQYhQKCp2vVimZmeHlYuPMxfB9+YdFNbVFNkxp1TdqUFVpWRarI29bg+zDnwREKapnpGfWXeiRlM/gkDMhbIasXQ5f+sbGF7esZPhPtFC2MhzbjIeoP22NGUMC5g5n8ngXuP58TqYdXRo0KgCgWaRErXAlSRI5Plr/QxNtFRkdmUIclJV+zAiD4MkhpXLB96DCYWHpT+EMuAd8hotnp/cI+msl/7t6uAcjKtMYf9hX0F0dowQ8nxyHwJGUI/u13YYHv/pLjjULwB37w/gVOwvhrr1u8qbRBa+kNNIaXkYJj6LXBb+EM0She1RiylHu2KwI6JB6qnjzhtqvft+LK+xfK07O5Hoz8H3eZPDT5kxiH7j3TU7SWX/7nNdO6SvxTavO8KXRcdiaSQldkBC9/hL24CaflzI+R3cpZOMEE9sHgJwivP3L3cDeUQnxmiX41iEXT5HjXa/Qnz+d2b0a5G+QhT9O+DQFmhMNJGH2AXrR+YEE6pzgZq1B1aMmwYUs+suJfCzL1bFg7fk/t1JOvlHG6LJZDojeKoL5XGcDHewrQagaBOxAGbiz5Jme+zj7auunHGjjS8h+uNhLb4slQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(366004)(39860400002)(346002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6512007)(53546011)(6506007)(6666004)(66899024)(83380400001)(86362001)(31696002)(38100700002)(36756003)(2616005)(26005)(2906002)(44832011)(31686004)(8936002)(8676002)(41300700001)(110136005)(4326008)(316002)(66476007)(66556008)(66946007)(478600001)(6486002)(966005)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1RaSVRmbDB4QkdBM2xYbFhiN0xlYU5raTQ2b21yZkRmN1RDZFpHcysyM3Av?= =?utf-8?B?VERST2V3Y0pBZmpTT0xRTlZmL05QVjlkMlhzQy92Y04rRGxESmJHRHFjZnJL?= =?utf-8?B?by8ySjFtdmhlTHhNSXZjOFQrVkJsa3VFSTNKVzVIVlpUTTRBYy9sZkQzRUk3?= =?utf-8?B?am9DZFBpcHh5Z2xZbjN1NzdOMVRDRkNRWHlydUFtVGhGUEx0ZG5YU002Rmgy?= =?utf-8?B?c3ZONmdyQWs3RUppSGFIQWJFUk9RYUlCQVZSTDdEUTVLQnJldW54Q3hCTVFZ?= =?utf-8?B?b3FpZHFHMG9jRk5uemJESDJhaVRJQ1I2UXNydzM0Uk96OW5GbDdScExweU5a?= =?utf-8?B?RUh2OHFXRkdJWTY1RFpYb0E5MzViSWRaVjRIaENRR1RJSFNrVElCVDJQWTMz?= =?utf-8?B?Q2pZbGZWQTE3TDkwVUlXVGRnM3QyUmdqRTNRZmhxK09ESFVhSGZ2RkpmUVN3?= =?utf-8?B?VFFzUUtYaWxEb3lJSzVBV29Rc1ZiTXljZitQSFljb2x0d0c1N0JrTUNrTk9a?= =?utf-8?B?QnI1aHBqZWwvYjR4SjhycDNsVU11WSt3VktKdVpBTndBQ2w1ZitZWm9zRG9T?= =?utf-8?B?MFRXSmpueUZYb0V5ZjV6OHcvaHdickNWKzJRV3VZKzcva0lURDhmS2k5aFUv?= =?utf-8?B?bDFsRExBUG1FN2p1OU1vNzM1ZWJ6UkUyT3JYUy9VL2xBVkhlMFdsbXpQeW9a?= =?utf-8?B?b29nc0JZaUl4ckZxYld4UEs4NGFTYUEwZHRtUEZNVE1oaGZCZzVEeGhhVTRw?= =?utf-8?B?STFqZUFlcXpCSGswMVUyUGxIS2drSU5wZDVEaVhZUWM3WkYyQlJFdnhBWUdG?= =?utf-8?B?STJqMGU1OGgzSkdOZUpRNno0cjZlQmdNVXF3TDJockxQZlJPa1VuODNpbXhv?= =?utf-8?B?UkdsNWNvWkkvT0xhQTRwd1hqNE82THFoRzNtb0FXZzNFWG02VThqNFZHUkhK?= =?utf-8?B?dTRDMEt1ZmhiM2FKNWwvTE5qak5DUGpKeXFBbXNORWxJQ3ZVdG5mN0V2enVG?= =?utf-8?B?cXd0UHFrZFphaHNLY0VKbjU0ZXdrWXQ3KzlJUnZ2Vk5ORlFjMytRNUdrUVQ5?= =?utf-8?B?ck9oblhxSVF3SWdxeE51TFJmNVVjdmlDbGNOaDRZeVBqYkFBaHhrNjB4RERx?= =?utf-8?B?cmJhQjFJRGgza2h0aUlzOUU0YzA5Wk56VVhXZFNCVWdFelFUVWwvVTV0a2py?= =?utf-8?B?SzZIQ2I5Z1ZsR1VjMlNRUE9CczVHQ1RYdFdPeHpRWnZJTkN4RTB5TFdvQXFn?= =?utf-8?B?bnJDTHFIWmh3WFBERm5zaEhxNVdGRkxRZVBsMk5FY3lCa1NNMmsrS0NwNit0?= =?utf-8?B?ZTdlSVB0VmJ1bDYzV0VJZllFZi95QzMreXgwV1ZMeWdKQUZONW5JcGJBMFNo?= =?utf-8?B?a3J0UGFHMC9LWDMwMmd4WG5HcDdhRVJEbmYxbHNlcWc3N1BiM0M1b3RqKzRV?= =?utf-8?B?TjlIVWs4N2VDSG5HUDRnbmFPUEtvT3BYb2hHbXFGbFh2QUxhVGV3K0s0UHI2?= =?utf-8?B?N3pyZXAvQkdMNU83TDFZV1dFSzVlcWlYUktCNG5zM2dxc3ZwTjZPVGdIRXJj?= =?utf-8?B?bmJTdUZLVGZLN2VXQVM4UVVtR3NESGV3KzJhQ2V6c0FFaTRJVnUyNkIybU8z?= =?utf-8?B?bE5FbGVPWCtCTGdMQ21iL294MUFVTzZ4eTRXM2dxTjVoVS9LNmErNEtpeU14?= =?utf-8?B?M2xORDRrVy9NNnFhNk10ekJLYThUWHNpY2Q2QkpPb3RIajdRZndQMzFkb2VE?= =?utf-8?B?T3J2S25sdkpab21XL0g2UFp1UHU2cWZ2MWczblYxWEVBWWZ1ZGh0d000QWtK?= =?utf-8?B?aC9sK1FkMzJ6b0lpdDlKSGZyUGR4anRpY3haOTUwUG5xNldXT1Jhc0M0R0Yx?= =?utf-8?B?ZjZpeVN3eWROc29pU25rTVliTlR5RmI2RmpYUjFzUFN4eEU2ampBdTFtOUlU?= =?utf-8?B?MjVPb0Nwb1JuWERCdGNPYjFSQXhwOVNWMUFMeXNwei9UcjRMNjJnUmZIallO?= =?utf-8?B?M1ptbVFxMW0zdk5sbkFXN1VmSHorTjVqOHFoMEFDT2hYdTYrSnpPRWo4Tjhr?= =?utf-8?B?M1ZQUWJZZ3dCRXhab2lHenlBditVdmJ6VGQzVFV2OXJTYVZUQTZGU2RHK1Ar?= =?utf-8?Q?F5n5J8u/acELs5LLacs0UGlxL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e1eb28-2231-47f7-3fec-08dbc0219993 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 12:51:14.8705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AOCBom9L0E2uxCQM4PFtE18LT53AbShRTxVtFh3uJKA8C9Bk1S53zMxqpHbiXp9M X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6604 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/22/2023 7:41 AM, David Marchand wrote: > Hello, > > On Fri, Sep 22, 2023 at 4:41 AM Jie Hai wrote: >> On 2023/9/19 0:54, Ferruh Yigit wrote: >>> On 9/8/2023 12:50 PM, David Marchand wrote: >>>> On Fri, Sep 8, 2023 at 1:32 PM Jie Hai wrote: >>>>> >>>>> The DPDK framework reports the queue state, which is stored in >>>>> dev->data->tx_queue_state and dev->data->rx_queue_state. The >>>>> state is maintained by the driver. Users may determine whether >>>>> a queue participates in packet forwarding based on the state, >>>>> for example, >>>> >>>> The driver is maintaining this state in dev_start / dev_stop and per >>>> queue start/stop handlers. >>>> >>>>> >>>>> [1] 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding" >>>>> [2] 141a520b35f7 ("app/testpmd: fix primary process not polling all queues") >>>>> >>>>> Therefore, the drivers need to modify the queue state in time >>>>> according to the actual situation, especially when dev_start >>>>> and dev_stop are called. see [3] for more information. >>>>> >>>>> [3] https://inbox.dpdk.org/dev/20230721160422.3848154-1-ferruh.yigit@amd.com/ >>>>> >>>>> This patchset also resubmit the patch [2] and makes some fixes on the patch. >>>> >>>> I just had a quick look at some patches and I wonder if a better fix >>>> would be at the ethdev level, rather than fixing all drivers. >>>> >>>> >>> >>> I came here to make the same comment, >>> >>> Jie, I forgot if we discuss this already but, >>> >>> does it work if we update queue state in 'rte_eth_dev_start()' & >>> 'rte_eth_dev_stop()' when 'dev_start' & 'dev_stop' dev_ops succeeds? >>> >>> This solves the case driver forgets to update the queue state. >>> >>> >> Hi, Furrh and David, >> >> It's OK for dev_stop, but not enough for dev_start. >> Some drivers also support deferred_start. >> Therefore, not all queues are in the start state after dev_start. >> >> If we want to get that correct queue state at the framework level, I >> offer the following options: >> >> step 1. A capability(e.g. RTE_ETH_DEV_CAPA_DEFERRED_START) is added to >> the framework, indicating whether the driver supports deferred_start. >> The capability should be reported by the driver and user can get it by >> rte_eth_dev_info_get(). >> step 2. All drivers that support deferred_start should report configuration >> information about deferred_start through >> rte_eth_rx_queue_info_get |rte_eth_tx_queue_info_get. >> step 3.The framework updates the queue status based on the support and >> configuration of deferred_start. > > rte_eth_dev_start must only update the queue state if > rx_deferred_start is unset (see struct > rte_eth_rxconf::rx_deferred_start). > And the queue state needs to be updated in ethdev > rte_eth_dev_rx_queue_start/stop. > > So I don't see where we need a new capability. > > Hi David, Problem seems 'rte_eth_rxconf::rx_deferred_start' is not stored in ethdev level, so rte_eth_dev_start() can't use it. And although application can request it, via rxconf, it is not clear if driver supports it or if it will take into account, that is where a capability flag can be useful, but it is a big change for this patch.