From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ipc: fix undefined behavior in no-shconf mode
Date: Wed, 24 Oct 2018 16:47:21 +0200 [thread overview]
Message-ID: <4205128.QQKyTifBQP@xps> (raw)
In-Reply-To: <59545f64-3fff-b046-d212-f134fe55de77@intel.com>
24/10/2018 12:20, Burakov, Anatoly:
> On 24-Oct-18 11:05 AM, Darek Stojaczyk wrote:
> > In no-shconf mode the rte_mp_request_sync() wasn't initializing
> > the `reply` parameter, which contained e.g. a number of sent
> > requests. Callers of rte_mp_request_sync() might check that
> > param afterwards and might read potentially unitialized memory.
> >
> > The no-shconf check that makes us return early (with rc = 0) was
> > placed before the `reply` initialization. Fix this by making the
> > `reply` initialization occur first.
> >
> > Fixes: 5848e3d2813c ("ipc: support --no-shconf mode")
> > Cc: anatoly.burakov@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-10-24 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 10:05 [dpdk-dev] " Darek Stojaczyk
2018-10-24 10:20 ` Burakov, Anatoly
2018-10-24 14:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4205128.QQKyTifBQP@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).