DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: ssebasti@amd.com, dev@dpdk.org
Cc: Ravi1.Kumar@amd.com
Subject: Re: [dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx
Date: Wed, 4 Mar 2020 17:14:23 +0000	[thread overview]
Message-ID: <4209bad8-fe8a-7252-5ac9-6f4a581e530d@intel.com> (raw)
In-Reply-To: <20200304134414.32762-1-ssebasti@amd.com>

On 3/4/2020 1:44 PM, ssebasti@amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian@amd.com>
> 
> Enable scattered rx support and add jumbo packet receive capability
> 
> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>

<...>

> @@ -249,6 +249,10 @@ axgbe_dev_start(struct rte_eth_dev *dev)
>  {
>  	struct axgbe_port *pdata = dev->data->dev_private;
>  	int ret;
> +	struct rte_eth_dev_data *dev_data = dev->data;
> +	uint16_t max_pkt_len = dev_data->dev_conf.rxmode.max_rx_pkt_len;
> +
> +	dev->dev_ops = &axgbe_eth_dev_ops;

Is this assignment required, isn't it already set in init (eth_axgbe_dev_init)?

<...>

> diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c
> index 96055c25b..57e2bbb34 100644
> --- a/drivers/net/axgbe/axgbe_rxtx.c
> +++ b/drivers/net/axgbe/axgbe_rxtx.c
> @@ -307,6 +307,152 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	return nb_rx;
>  }
>  
> +

monor nit, there is additional empty line here.

  reply	other threads:[~2020-03-04 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 13:44 ssebasti
2020-03-04 17:14 ` Ferruh Yigit [this message]
2020-03-05  5:27   ` Sebastian, Selwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4209bad8-fe8a-7252-5ac9-6f4a581e530d@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Ravi1.Kumar@amd.com \
    --cc=dev@dpdk.org \
    --cc=ssebasti@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).