From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E8DA0544; Tue, 5 Jul 2022 21:56:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80DED40223; Tue, 5 Jul 2022 21:56:26 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id E63FB400D7 for ; Tue, 5 Jul 2022 21:56:24 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id AEE363200905; Tue, 5 Jul 2022 15:56:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 05 Jul 2022 15:56:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657050983; x= 1657137383; bh=DB2pAAmiJiql1LDw5qcc3r6FZk5sPTkcT4BN/QNMC7A=; b=b HD/6/ytFeDv0R6DIic0ba8qXyPgFYuiVLDoPisLbOilFY1oEjZlyAnYztkYPPEY4 YtMgZRN4nLmS65khwsTy5asM8yO6w8fR96dZpkSsu2tFacDAD8L18laK9dc95fQK eWD8X9md2HyLKOUFk7TmwApAWml1NV9Rde6Jvk3JkXxgeAvb+/n7KMsNo0LMIJ57 VfqVQMSxu4Uiwa9JRX9T9+Je9nCORHDTCPLU75U9tNrB5TCJUwUYnVPUDzv/zt+G 5htUST5HHvVDNCk64XxTuFNQcnQRK3LwnKUFo3zYGBR0z26S3FpHwd0YprGtJw0h O6gR1norq1xOua+bCwCUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1657050983; x= 1657137383; bh=DB2pAAmiJiql1LDw5qcc3r6FZk5sPTkcT4BN/QNMC7A=; b=Z qu+prDSrNAhGCklE3GOkFt5Ya2XTfT5BKtFwO5sq8Gz25wy5ptAQXMdRr34w5HQJ xQHTAMdIrMKpp9ETjejs29dHL39tTtDZPc9FX8bk4eDjKLKCtbph2qcDwt5Cg1Qj BeARWjJcqpGO7KWz6m3yHA7WwB3YUZ4xd1rt0IPyCZ2DXYPhHYcX+xzYLObqHZxZ cp3rU5iIralKsmY+UFKDx72Y318NWvy3TJLLyekrRZHz5HMoDNwXTo37wSDYDwmp sXbWvBWtAgLZSV9ww1icVKAbI4mahffu8Hmw4JokPcpuqMO85l5fUkPZko+0FJMw 8Aes5nTo/CWpQZ4AgRElA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 15:56:22 -0400 (EDT) From: Thomas Monjalon To: "Guo, Junfeng" Cc: dev@dpdk.org, "Wu, Jingjing" Subject: Re: [PATCH v2] raw/ntb: add PPD status check for SPR Date: Tue, 05 Jul 2022 21:56:21 +0200 Message-ID: <4219355.BQQF58Tnoo@thomas> In-Reply-To: References: <20220630083924.175373-1-junfeng.guo@intel.com> <20220630085616.183562-1-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Add PPD (PCIe Port Definition) status check for SPR (Sapphire Rapids). > > > > Note that NTB on SPR has the same device id with that on ICX, while > > the field offsets of PPD Control Register are different. Here, we use > > the PCI device revision id to distinguish the HW platform (ICX/SPR) > > and check the Port Config Status and Port Definition accordingly. > > > > +---------------------------+--------------------+--------------------+ > > | Fields | Bit Range (on ICX) | Bit Range (on SPR) | > > +---------------------------+--------------------+--------------------+ > > | Port Configuration Status | 12 | 14 | > > | Port Definition | 9:8 | 10:8 | > > +---------------------------+--------------------+--------------------+ > > > > v2: > > fix revision id value check logic. > > > > Signed-off-by: Junfeng Guo > Acked-by: Jingjing Wu Not sure it is urgent, anyway Applied, thanks.