DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ori Kam <orika@nvidia.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
	dev@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ray Kinsella <mdr@ashroe.eu>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Akhil Goyal <gakhil@marvell.com>,
	Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function
Date: Sat, 07 Aug 2021 21:34:08 +0200	[thread overview]
Message-ID: <4220837.bxmlJVP2Av@thomas> (raw)
In-Reply-To: <CALBAE1OAPu4=xHeQeZCWmFzR6pZhvmLohJMYZekMJVoHoisYdA@mail.gmail.com>

> > > Currently there is a dedicated modify function for each
> > > field that the application wants to change.
> > > For example:
> > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
> > >
> > > A new function rte_flow_action_modify_field DPDK added the ability
> > > to use the same function to modify any field, in addition to be able to
> > > modify the value based on different field and not just immediate value.
> > >
> > > Signed-off-by: Ori Kam <orika@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

> > > +* ethdev: Announce moving from dedicated modify function for each field,
> > > +  to using the general ``rte_flow_modify_field`` action.

This is a very vague announce.
OK we can replace a lot of actions with rte_flow_modify_field,
but it doesn't say when and which functions will be removed.
I think we should make a more precise announce for removal of some actions
in DPDK 22.11.

In the meantime, let's introduce this hint that something is changing
as it is acked.

Applied.



  reply	other threads:[~2021-08-07 19:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 14:10 [dpdk-dev] [PATCH 1/2] ethdev: announce change to action modify data Matan Azrad
2021-08-02 14:10 ` [dpdk-dev] [PATCH 2/2] ethdev: announce moving to general modify function Matan Azrad
2021-08-03  8:57 ` [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data Ori Kam
2021-08-03  8:57   ` [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function Ori Kam
2021-08-03 18:05     ` Ajit Khaparde
2021-08-07 13:33       ` Jerin Jacob
2021-08-07 19:34         ` Thomas Monjalon [this message]
2021-08-03 18:10   ` [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data Ajit Khaparde
2021-08-04 12:10     ` Andrew Rybchenko
2021-08-07 13:33       ` Jerin Jacob
2021-08-07 19:26         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4220837.bxmlJVP2Av@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gakhil@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=matan@nvidia.com \
    --cc=mdr@ashroe.eu \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).