From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 958EDA0C4F; Sat, 7 Aug 2021 21:34:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F0B740691; Sat, 7 Aug 2021 21:34:15 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 726E64067E for ; Sat, 7 Aug 2021 21:34:13 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id EE9AC58056A; Sat, 7 Aug 2021 15:34:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 07 Aug 2021 15:34:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 4tYySUl5QeBNo3+6ZptjtYRSdVXMi6p9aQ7RQKLFIns=; b=sUnu6/LwIQx5W22H YFIx4H96mjPxfLSWdCYosjdGu49wjhrJ0F8FG6Y66DzYdGonRjxtqL2xqRMeuufa fdckFVzi5Cr/QAoNzMRzS6QNuVgPO96a3ftwsaVBVPsPfE2FNmFyUNMXzekaFl68 DHbc2HxaZIBWq+n6ds3flUAYdLRqoJt5s4C11THp/KW5IdXWIlfeBywMrEpmNf9x H0M3A9/bvfYfRPYI4IEZl8ajzsJdbN6v3nee41X/2qNRJSEKVeMZaCql+RxjU/pt MDiS6XOTCC7ETYxIOjGgcoh7yUOVCf6BvHfy1MYRdpcNUw4cZmRSXkIWwv6f4uyq bej5wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=4tYySUl5QeBNo3+6ZptjtYRSdVXMi6p9aQ7RQKLFI ns=; b=SQmLLxSKqCb05bBt10ypKHHOzd2VCr+ckNmX1M5zjRTFkHaS61UZYyEKp 8fyFnvIXIo+LRA6HeCe3l8WfkLgVQdZ+jckLISvG3IyxHGJNJAQauEvxuCGYhDP8 MoXs2wLq8daf5FlmH3WyEo6QEMVxxhY1Bv914T2Tl2PDy0ZC2Rl8feBajTJFn915 5mjYYmjwQFmkq8CkJqynNWNqKAGY4GcpWdh0oWn85XbPEZp0w2zkkBvBoEzc4lcr sowOGomgt2+C2gC/MZuwsb1xuE3qHyKtSvnAbaiyZQA93mj9oMQZWxJgusY8eTM+ s0jqM0YdhrocZW+8EIn6b9NFV7zKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeefgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Aug 2021 15:34:10 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: Ajit Khaparde , dev@dpdk.org, Andrew Rybchenko , Ray Kinsella , Slava Ovsiienko , Ferruh Yigit , Matan Azrad , Raslan Darawsheh , Akhil Goyal , Jerin Jacob Date: Sat, 07 Aug 2021 21:34:08 +0200 Message-ID: <4220837.bxmlJVP2Av@thomas> In-Reply-To: References: <20210802141004.353754-1-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > Currently there is a dedicated modify function for each > > > field that the application wants to change. > > > For example: > > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. > > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4. > > > > > > A new function rte_flow_action_modify_field DPDK added the ability > > > to use the same function to modify any field, in addition to be able to > > > modify the value based on different field and not just immediate value. > > > > > > Signed-off-by: Ori Kam > > > Acked-by: Matan Azrad > > Acked-by: Ajit Khaparde > Acked-by: Jerin Jacob > > > +* ethdev: Announce moving from dedicated modify function for each field, > > > + to using the general ``rte_flow_modify_field`` action. This is a very vague announce. OK we can replace a lot of actions with rte_flow_modify_field, but it doesn't say when and which functions will be removed. I think we should make a more precise announce for removal of some actions in DPDK 22.11. In the meantime, let's introduce this hint that something is changing as it is acked. Applied.