From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CC9E51B634 for ; Mon, 5 Feb 2018 23:45:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4CA1120E9C; Mon, 5 Feb 2018 17:45:31 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 05 Feb 2018 17:45:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=OojaFIimS0hoI/cn1VpkOLg2HJ DeBPh2/5Nju8RuFp8=; b=B9oqbFD7gJkRiORNTTw/d5ldbxMe+yuZEQuYiPEc0N 3wcZa1N3C5D6A+wtoYuMiIAaO1lA8V0KZ7GypO+nkhwOzyFS0qrlbi5CB3JU/2SA paXnISbHOJRWqWmRED//tO98xKpGTQpFAJhHM84eIo+bsb1z6MfXGWkXAjOghuaS o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OojaFI imS0hoI/cn1VpkOLg2HJDeBPh2/5Nju8RuFp8=; b=QmNpK3NxHYve1aDNzlQIuW G8lSEyqO4mh7yOtEWspddXfwcCfMlGjmHwO23T5qBOtnXDZb26YLiso6iA4/24Bx kS3ADrI2LeN7jEcRBHnEe7W/G+gtivoKrl1eAhNSpoIEah8dLKaVDAv39ZycfJzJ 3kCDiSf4rP7hj4P5N7//dOurH3Uk9SrGQ6s8tXTBbVzMH7TLVLWDtGrhIb/x4BQE xYpTNiHXueOCvldn3OtIqdbrDptR+c5fSqSy6nnjLdr+u/tHakngIJy2zINGF3eK BMI6stPn3aQrU2m2hHGEOWtiNfnGBycMmSXrbiC/jv7yei3iaE0lVXLFQ0EdBeKA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 029C07E3DF; Mon, 5 Feb 2018 17:45:31 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Mon, 05 Feb 2018 23:45:27 +0100 Message-ID: <4220934.KFJTx7yznj@xps> In-Reply-To: References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 22:45:32 -0000 05/02/2018 18:39, Burakov, Anatoly: > On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: > > During lcore scan, find maximum socket ID and store it. > > > > Signed-off-by: Anatoly Burakov > > --- > > > > Notes: > > v3: > > - Added ABI backwards compatibility > > > > v2: > > - checkpatch changes > > - check socket before deciding if the core is not to be used > > > > lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- > > lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ > > lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ > > lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- > > lib/librte_eal/rte_eal_version.map | 9 +++++++- > > 5 files changed, 92 insertions(+), 14 deletions(-) > > > > This patch does not break ABI, but does it in a very ugly way. Is it > worth it? I think we agreed to not get this patch in 18.02. Did you change your mind?