From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 937661B50F for <dev@dpdk.org>; Tue, 9 Oct 2018 13:53:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 312F921E6D; Tue, 9 Oct 2018 07:53:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 09 Oct 2018 07:53:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PPSDiBj1UikmOvi/+HO6FfMBezjsyJYMhWBVd4rJq48=; b=BiNc0BM4NUjX gzdNitNmJ21l9uJZKF6+IHTc+lt7bUrHHb7ldpHMIo+dH631Ulr/KsTWjk8w24zY LS5XbJaEDwi8tpmtqA2EhkRMvGRMkemiBH6CN4pYPGZIa11RbO7nZ8sSX8+Jgc8m ieLI/91ScHfLDo3Si+PdcIE9eaTjBz4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PPSDiBj1UikmOvi/+HO6FfMBezjsyJYMhWBVd4rJq 48=; b=myw/Vbw0NVSqBzP+OUyq6mFTRd05x2kR3aQEbnrSAmLAJa87T9a921Dp8 Bg8g//rPaDqLPK5eVvgPauQFWPY6i2GmgYn4aqYZQ2UXmT6X469GBSUAcmooFNH6 fDQ54IatFgdG9yT4VpJzB3Djlf1sgywI1s+6prRwxMClPEp5HsrRX+WuFU6WSWLV zaI0Ls5eVmggZIKF7CbIW0x6IbrC845hZLTphPqPCk7M7tuC5J/Tot8YMtRybNyW Ioj67R1bqH1lSWf/kSsla0qVPkiW9qkiGoNqTYqggoGD/XE5NopVZ3RagE7ZwvEK VRRrG+OzuTvLvLZzlD933u9FZFqIA== X-ME-Sender: <xms:zJa8W6H3T07w4DsbA7ioF7TE0n-4yF9vFb_HeRYsJIth4bDvktaUSQ> X-ME-Proxy: <xmx:zJa8W5YHeYdmTZ25qaiXLnKbdbnx9ou-Ru-Ku9ts5Qmv4tG5jNhY_w> <xmx:zJa8W_4jtzvmgggWj1s0oDbcD1mHPDzc9X8NXbHQ1fzmqmnDgc4pGw> <xmx:zJa8W_xFxsXHV7MJnFR5VkGO1DhV3EJgpamt8gZbXbxKqKCCtVLITA> <xmx:zJa8W0WVU62sYy8b-nZSD_qN1yApgCLnmsWDvYxZAnx2axNfvzqRBg> <xmx:zJa8W8LBTl4-yGfUlDJn1fpuOOC4HXtpaIwqC7wStSf7XAM3B9jpQw> <xmx:zZa8W6aRPtGzMNwbxNkvVwR37lnP6WnNKKii6ErpbvPGfgkculCSIQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 357C5102EB; Tue, 9 Oct 2018 07:53:47 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Neil Horman <nhorman@tuxdriver.com> Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com, remy.horton@intel.com Date: Tue, 09 Oct 2018 13:53:46 +0200 Message-ID: <4229908.dRXGeFGLpr@xps> In-Reply-To: <20181009114320.GA17331@hmswarspite.think-freely.org> References: <20181009021858.19216-1-thomas@monjalon.net> <20181009021858.19216-3-thomas@monjalon.net> <20181009114320.GA17331@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] mk: remove broken check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 09 Oct 2018 11:53:49 -0000 09/10/2018 13:43, Neil Horman: > On Tue, Oct 09, 2018 at 04:18:56AM +0200, Thomas Monjalon wrote: > > Next patch does not pass the experimental check > > because it has an (unrelated) experimental function in his context. > > > > Cc: Neil Horman <nhorman@tuxdriver.com> > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > mk/internal/rte.compile-pre.mk | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk > > index a734cbbd0..acb9796fa 100644 > > --- a/mk/internal/rte.compile-pre.mk > > +++ b/mk/internal/rte.compile-pre.mk > > @@ -75,7 +75,6 @@ C_TO_O_DO = @set -e; \ > > echo $(C_TO_O_DISP); \ > > $(C_TO_O) && \ > > $(PMDINFO_TO_O) && \ > > - $(CHECK_EXPERIMENTAL) && \ > > echo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \ > > sed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \ > > rm -f $(call obj2dep,$(@)).tmp > > NACK. Yes, of course. I have added this patch in the series in order to allow building the patches. > Its a bit vague to get the meaning of your changelog, but based on the > context of the actual other patch I think what you're saying is that patch 3/4 in > this series has the __rte_experimental token in it as part of the context of a > diff, rather than as a change itself, and the check-experimental-syms script is > matching on that when it shouldn't. The correct fix is to teach the difference > between changes and context to the check-experimental-syms.sh script, not to > break the whole thing by just removing the call to the script. I agree, but I don't understand how the patch context is related to the checks done in buildtools. Please could you fix it? It is blocking the integration of this series. Thanks