From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id B8E5F6835 for ; Wed, 2 Apr 2014 11:00:16 +0200 (CEST) Received: by mail-wi0-f181.google.com with SMTP id hm4so43149wib.14 for ; Wed, 02 Apr 2014 02:01:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TCQ7YiYw3MfhImdAF1NZhbr2DTCZKcqxwCW4Sf+EyMQ=; b=nMS5VOoj45wa2zo5f0qw/SvPWghgeXc9tSODGRG8DtUZfxs3U4V9IV+dQ+ZGFEn5rM cAjFbT5lKK9PdW68Dwbg9JjvzoBHUDg5P7xH0rzSNuD3iwg4Yd6OFAaZZacivsE5hzq2 Sd+R1lLt+VmWUMmW1I1ABDNg3EyBi5pkGgdHOKNiboPP6WguhgBvOzWLpkMZqFsYiQz8 /qmtjwQt/twzScffZ9/mmIRAenko8twBpHRl1TTsz55a6zbc5FaBACjAWWWm2fpyJ7+j Yhxm+okbRYCmm4WhQeF7teGRyDgf5MT+HMFK8Gv4w8pylQ3qudNlMLpNcT/CWE0bnsMA Qkcg== X-Gm-Message-State: ALoCoQlMthKa4YhdWMoNup+5uk2865+PqJuiZOqYfMB257oLM8Tkb5xuBV7Bt0iNUJnjjDAOOEi9 X-Received: by 10.180.105.65 with SMTP id gk1mr27031116wib.12.1396429311494; Wed, 02 Apr 2014 02:01:51 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id t18sm3376163wiv.16.2014.04.02.02.01.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Apr 2014 02:01:50 -0700 (PDT) From: Thomas Monjalon To: Chris Wright Date: Wed, 02 Apr 2014 11:01:49 +0200 Message-ID: <4232273.mks7Rollq1@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <20140224165208.GF27503@x220.localdomain> References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com> <1391529271-24606-4-git-send-email-thomas.monjalon@6wind.com> <20140224165208.GF27503@x220.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 03/16] pkg: add recipe for RPM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 09:00:17 -0000 Hello, Sorry for the long delay. 2014-02-24 08:52, Chris Wright: > > pkg/rpm.spec | 143 > > This should be dpdk.spec Actually it should be dpdk-core.spec. Since it is a file hosted in the project, is it mandatory to have such naming? Could you explain why? When building it with "rpmbuild -ta dpdk.tar.gz", the .spec name has no importance. > > +ExclusiveArch: i686, x86_64 > > +%define target %{_arch}-default-linuxapp-gcc > > What is this for? Multi-targets builds are supported in DPDK Makefiles. So the target must be explicited when building. Is it OK to define such variable here? > > +%description > > +Dummy main package. Make only subpackages. > > I think the core package should have the .so, the -devel package w/ > headers, and no -static package. Including a .a file is discouraged in > Fedora OK > > +%package core-runtime > > perhaps just 'runtime' [...] > > +%package core-devel > > name this devel No, dpdk-core is a name to differentiate the main component and the extensions such as dpdk-memnic. So we should have dpdk-core and dpdk-core-devel. Do you agree? > > +# debuginfo packaging is broken > > +%define debug_package %{nil} > > Can you add a better comment why it's broken? Yes, I think it's due to direct use of ld linker. > > +make O=%{target} T=%{target} config > > Did you try to update the build system to output into $RPM_BUILD_ROOT > directly? It's much preferred compared to the cp/rmdir below Probably we could change the build system but it should be another patch. > > +%install > > +rm -rf %{buildroot} > > +make O=%{target} DESTDIR=%{destdir} > > Why make again (IOW, why not in %build section)? This one is for installing files only. Isn't it the role of %install? > > +mv %{destdir}/%{target}/kmod/*.ko %{buildroot}%{moddir} > > Normally I'd use install command (-d will create directories) Yes but here the strategy is to dispatch some files and keep the remaining ones in %{datadir}. Thanks for the review -- Thomas