From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BDB6A6CD7 for ; Thu, 26 Apr 2018 22:24:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4BABE218FE; Thu, 26 Apr 2018 16:24:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 26 Apr 2018 16:24:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=7QVx/IcKJqkEmr5RTIjWTvb/ld rQOfLMeCtUD0Xwrto=; b=QAN/gq5pd3mcIDzej5b5ofe2Sgqw8Hn48ISN17mpCx a67hMDF8J46W0ZDiuZI62H9s5HyQPX2pu6bCBFWA1nNjfamU6sf84LJaHTCd8HjK QqO9ialDm1UvCYJA+1gVZ1Z+rpnZegNjxDRJKaTzfYEU2tXMupDmYpYY9Zj/B8D0 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7QVx/I cKJqkEmr5RTIjWTvb/ldrQOfLMeCtUD0Xwrto=; b=FoCz/orYrkmeqKGAIqEA2v rgqRQUub/lvt0pA+p1zDI5qCe3vx6vUY1LJp5HFIx8mG/LQw1ThqsRPKc4Uo1/eY m8zxxHZGwQmTeAid2MXtbuMX6e4n8ay0MOpmm9d4VuuA+FYANcMz0ml+K2UdY8os FR4h30BOwhn/i+PwEnQmjQKq2PdhRMQscw7PSwiO8GKn9Bd22SqIuRrW30g7LWfS kQUDaYNyHzXT1NWB6SrWa85iVswF5E4/9MEZanynlHJSz2Xd0D1q3mMAPFVJnvki FoyvHmknZjGAwQvhHttxmMzpEDdomYzejo6scN/KKfKE5gnxq/LY0cXhu/HfIKlA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED619E4122; Thu, 26 Apr 2018 16:24:19 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz , Yongseok Koh Cc: Andrew Rybchenko , wenzhuo.lu@intel.com, jingjing.wu@intel.com, dev@dpdk.org, konstantin.ananyev@intel.com, stephen@networkplumber.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Date: Thu, 26 Apr 2018 22:24:18 +0200 Message-ID: <42381112.Sh1zumz044@xps> In-Reply-To: <20180426200737.hhgj4pkvs2qc63bw@neon> References: <20180310012532.15809-1-yskoh@mellanox.com> <3222860.1kATvoXXQV@xps> <20180426200737.hhgj4pkvs2qc63bw@neon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 20:24:22 -0000 26/04/2018 22:07, Olivier Matz: > On Thu, Apr 26, 2018 at 09:58:00PM +0200, Thomas Monjalon wrote: > > 26/04/2018 21:42, Olivier Matz: > > > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > > > 26/04/2018 18:05, Andrew Rybchenko: > > > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > > > > > > > > > We have discussed that it would be good to deprecate RTE_MBUF_INDIRECT() > > > > > since it is not !RTE_MBUF_DIREC(). Is it lost here or intentional (may > > > > > be I've lost > > > > > in the thread)? > > > > > > > > I think it should be a separate deprecation notice. > > > > > > Agree with Andrew that RTE_MBUF_INDIRECT should be deprecated > > > to avoid confusion with !DIRECT. > > > > What do you mean? > > We should add a comment? Or poisoining the macro? Or something else? > > Should it be removed? In which release? > > Sorry if I was not clear. > > Not necessarly remove the macro for this release. But I think we > should announce it and remove it, following the process. > > I suggest: > - for 18.05: send the deprecation notice + add a comment in the .h > saying that the macro will be deprecated in 18.08 (or 18.11, there > is no hurry if there is the comment) > - for 18.08 (or 18.11): remove the macro (I don't think poisoining > is useful in this case). OK it works for me. I think we can wait 18.11 for a complete removal, except if the mbuf API is broken in 18.08 and not 18.11. But we probably need to do a soft 18.08 release without any breakage at all. So, Yongseok, please prepare a patch including a deprecation notice with a fuzzy removal deadline, and a doxygen comment. As it requires a special process (3 acks, etc), it is better to have it as a separate patch. Thanks