From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C0D9A0524; Thu, 30 Jan 2020 23:44:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C07B71C035; Thu, 30 Jan 2020 23:44:46 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id A6DA91C033 for ; Thu, 30 Jan 2020 23:44:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 196CAF738; Thu, 30 Jan 2020 17:44:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 30 Jan 2020 17:44:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BQIYsczabFQzvgnzd6QhTfpyPw8MiP6MVR/ghnbDDkw=; b=s18DbGC4YrBI t27CiGNU60E+luYX+fgtiv0k/JpSwzHT28ek0mxnmFVllsvJnUuKqXTPrD3wkc79 bZ7+rnYM/OsoJDeqv2DNXuqKBQs/rj8t2fyceZhkE7BJMj349w7FFzcirXUT02uw FuYtFiJDqnmeGhyZbuFA+HOCCDbZS/4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BQIYsczabFQzvgnzd6QhTfpyPw8MiP6MVR/ghnbDD kw=; b=hpTZZHGGWT/E90a41vdBlYus19lF8rxWA/7UE6sWCAKdGY+kN5Y8/+KjB vTKJL1ZOZIFmAz6FVler6zIivxdwqj2ukFtbe1DiioKaRROrAFne1An1bNLULRKn nVTbSUvEu4kteKoyHyUoVgveESwQ2dFgZgU6tBqsYSu+R32eDlVfoAncr3yPe+z0 kBak5ZXv4VsgE311psdWFZ+ebn228sfM8YBjDWtEEPV29iK57ppDkXvDmdQb39X6 bioJZ9TJeqW6RkNa0VXtJTxk9UwPM6Eet1SeMOV2P5L31vMEQqEqHAzPmve126kx bLuyzXgDfMNtQTNWd7yovcWlY4MsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeekgdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 706E1328005E; Thu, 30 Jan 2020 17:44:42 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, kevin.laatz@intel.com, aconole@redhat.com, nhorman@tuxdriver.com, akhil.goyal@nxp.com, anoobj@marvell.com, bluca@debian.org, fiona.trahe@intel.com, ferruh.yigit@intel.com, Michael Santana , John McNamara , Marko Kovacevic Date: Thu, 30 Jan 2020 23:44:41 +0100 Message-ID: <4248333.Wku2Vz74k6@xps> In-Reply-To: <20200130160009.6549-5-david.marchand@redhat.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <20200130160009.6549-1-david.marchand@redhat.com> <20200130160009.6549-5-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/01/2020 17:00, David Marchand: > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > +refsrcdir=$(mktemp -d -t dpdk-${DPDK_ABI_REF_VERSION:-}.XXX) Instead of a temporary source directory, could it be inside $DPDK_ABI_REF_DIR/$DPDK_ABI_REF_VERSION ? I feel it would more "hackable" for debugging of the process. [..] > + if [ -n "$DPDK_ABI_REF_VERSION" ]; then > + DPDK_ABI_REF_DIR=${DPDK_ABI_REF_DIR:-reference} > + abirefdir=$DPDK_ABI_REF_DIR/$DPDK_ABI_REF_VERSION/$targetdir > + if [ ! -d $abirefdir ]; then > + # clone current sources > + if [ ! -d $refsrcdir/.git ]; then > + git clone --local --no-hardlinks \ > + --single-branch \ > + -b $DPDK_ABI_REF_VERSION \ > + $srcdir $refsrcdir > + fi > + > + rm -rf $refsrcdir/build > + config $refsrcdir $refsrcdir/build $* > + compile $refsrcdir/build $abirefdir > + $srcdir/devtools/gen-abi.sh $abirefdir > + fi