From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: dev@dpdk.org
Cc: Harman Kalra <hkalra@marvell.com>, Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Question on a patch in lib/ethdev/ethdev_driver.c
Date: Mon, 11 Mar 2024 10:07:27 +0100 [thread overview]
Message-ID: <4250e68c-6874-4954-bf2a-406c22378db4@6wind.com> (raw)
Hello,
Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes
the following variable initialization in rte_eth_devargs_parse():
memset(eth_da, 0, sizeof(*eth_da));
This in turn causes a failure in ixgbe PCI probe on Arm server:
eth_ixgbe_pci_probe(): unsupported representor type:
Indeed, nb_representor_ports was supposed to be correctly defined when
calling rte_eth_devargs_parse().
The question is:
why was "memset(eth_da, 0, sizeof(*eth_da));" removed ?
This is not explained in the commit log.
Best regards
Thierry
--
Thierry Herbelot
CSE - Titulaire au collège Cadres
Senior Software Engineer
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
next reply other threads:[~2024-03-11 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 9:07 Thierry Herbelot [this message]
2024-03-11 10:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4250e68c-6874-4954-bf2a-406c22378db4@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hkalra@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).