From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D796443C86; Mon, 11 Mar 2024 10:07:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 673F4402D8; Mon, 11 Mar 2024 10:07:32 +0100 (CET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by mails.dpdk.org (Postfix) with ESMTP id E997D402AE for ; Mon, 11 Mar 2024 10:07:30 +0100 (CET) Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-dcbf82cdf05so2455473276.2 for ; Mon, 11 Mar 2024 02:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1710148050; x=1710752850; darn=dpdk.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=UJKFH87+EONxFMoJmC9X5USAytnB+VAcgRrYnkXhWrs=; b=NHt880gt1oWYmUlYFIrbA10sxn9le6yr9Dm368NUqzJWzx0nauPQSMPipUFDqModjH u2Dy7/n5BZrsNOc3akmB3rkMvwByt1jA9AQ6SPpxOR1kdt3Diz5zBmp8v0z0Rs+mfzrr LMQxpgsnkqITKXu90RyA//DlaXfs9wqvEUStZ7y8MXQz7tOUPG6EEaauoLpuF4MPUyGM xrh+XVfCNirG5JKJd1ftVFqpFDl0DJsq2IXHHoQ2PKJEkeQ7jqLtBTWB4FpBlLXgh812 5R4znVRoqmej+OwI1IQuCp667n+y6KF4rieg4OaVdLjrKN2hdlo4ikMg3K4houieloD2 1mmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710148050; x=1710752850; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UJKFH87+EONxFMoJmC9X5USAytnB+VAcgRrYnkXhWrs=; b=rFo6/TfTVdBPMLlzbjV1bmvmDXB6C86Z2a45seB52efNzN1f2SyqFeZKH4S4Fc1zRl t+3XXiK7Bp+Pq21M1sz9TW6M+fx2cOJ2RCc+AuRUqdgcvTc8DVFvFGpR5eYmgjB/ZGi0 jCnge6rAdmC8JCFqQv5c+xDBDFvlmTA7L+zUuHwBUVtDeabKSj9P/XqrbkTaig4QNaOa OrlB/WI1PH8Q/bHwmL1CzQ4WcmD1JzlMmV5PSdWlnu1qDNzbGowVDfQdvTk0L6YhGPob tRJqtN7sh4SaHxTKT8pMeroOIVkHGdCYTpynsdxcXC47OQtJEaqd2M0kJpBHRa/DMc/K 53zQ== X-Gm-Message-State: AOJu0YxnfNvvYnKBIYyEtuJLKrnhcFZITDVjBVfnJso1qhlp4OeJm+gf DM8SuRTsje9j3fiKCt/Fh5COLmdpqkrI91jIOYb7mKZKcd8zOu/meP6+GNT3flTgIKmOhNrvMJt z9Q== X-Google-Smtp-Source: AGHT+IGVWkeYRHiqTBVkpsTK/R97iB3gOEjYgtdU7hF2qlSd9Gqc/9pPAqXV0yZlt3IzS7g59bocew== X-Received: by 2002:a25:add9:0:b0:dce:fd56:b213 with SMTP id d25-20020a25add9000000b00dcefd56b213mr3940236ybe.7.1710148049809; Mon, 11 Mar 2024 02:07:29 -0700 (PDT) Received: from [10.17.1.39] ([185.13.181.2]) by smtp.gmail.com with ESMTPSA id f5-20020a5b0d45000000b00dcf35be9f51sm1020183ybr.24.2024.03.11.02.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 02:07:29 -0700 (PDT) Message-ID: <4250e68c-6874-4954-bf2a-406c22378db4@6wind.com> Date: Mon, 11 Mar 2024 10:07:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: dev@dpdk.org Cc: Harman Kalra , Ferruh Yigit From: Thierry Herbelot Subject: Question on a patch in lib/ethdev/ethdev_driver.c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes the following variable initialization in rte_eth_devargs_parse(): memset(eth_da, 0, sizeof(*eth_da)); This in turn causes a failure in ixgbe PCI probe on Arm server: eth_ixgbe_pci_probe(): unsupported representor type: Indeed, nb_representor_ports was supposed to be correctly defined when calling rte_eth_devargs_parse(). The question is: why was "memset(eth_da, 0, sizeof(*eth_da));" removed ? This is not explained in the commit log. Best regards Thierry -- Thierry Herbelot CSE - Titulaire au collège Cadres Senior Software Engineer http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware