* Question on a patch in lib/ethdev/ethdev_driver.c
@ 2024-03-11 9:07 Thierry Herbelot
2024-03-11 10:58 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Herbelot @ 2024-03-11 9:07 UTC (permalink / raw)
To: dev; +Cc: Harman Kalra, Ferruh Yigit
Hello,
Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes
the following variable initialization in rte_eth_devargs_parse():
memset(eth_da, 0, sizeof(*eth_da));
This in turn causes a failure in ixgbe PCI probe on Arm server:
eth_ixgbe_pci_probe(): unsupported representor type:
Indeed, nb_representor_ports was supposed to be correctly defined when
calling rte_eth_devargs_parse().
The question is:
why was "memset(eth_da, 0, sizeof(*eth_da));" removed ?
This is not explained in the commit log.
Best regards
Thierry
--
Thierry Herbelot
CSE - Titulaire au collège Cadres
Senior Software Engineer
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question on a patch in lib/ethdev/ethdev_driver.c
2024-03-11 9:07 Question on a patch in lib/ethdev/ethdev_driver.c Thierry Herbelot
@ 2024-03-11 10:58 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-03-11 10:58 UTC (permalink / raw)
To: Thierry Herbelot, dev, Thomas Monjalon, David Marchand; +Cc: Harman Kalra
On 3/11/2024 9:07 AM, Thierry Herbelot wrote:
> Hello,
>
> Commit 9a9eb104ed ("ethdev: parse multiple representor devargs") removes
> the following variable initialization in rte_eth_devargs_parse():
>
> memset(eth_da, 0, sizeof(*eth_da));
>
> This in turn causes a failure in ixgbe PCI probe on Arm server:
>
> eth_ixgbe_pci_probe(): unsupported representor type:
>
> Indeed, nb_representor_ports was supposed to be correctly defined when
> calling rte_eth_devargs_parse().
>
> The question is:
> why was "memset(eth_da, 0, sizeof(*eth_da));" removed ?
> This is not explained in the commit log.
>
Hi Thierry,
I think it is an oversight, thanks for reporting it.
+1 to preserve the existing behavior and function memset the input
parameter.
@Thierry, do you want to submit a fix? Else me or Harman can send one.
Thomas/David, can we hold the -rc3 for this fix please?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-11 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 9:07 Question on a patch in lib/ethdev/ethdev_driver.c Thierry Herbelot
2024-03-11 10:58 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).