From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDCA141EB2; Thu, 16 Mar 2023 18:47:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 524B340DF6; Thu, 16 Mar 2023 18:47:37 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 5502F40DDC for ; Thu, 16 Mar 2023 18:47:36 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F242F5C0037; Thu, 16 Mar 2023 13:47:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 16 Mar 2023 13:47:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678988855; x=1679075255; bh=ctE8I+bh+zObQorAgACu9RKFcOn0s7zBxu8 HFd+b51U=; b=hw4co34/ZZRiYOzuIiqjOcrWB+uLZzecIG1r9tCwoOAiGZBuD+j EiMxzmGZ3wwRJLb1HUm9I4lpTqamHy6TxYuOcN/fp4IxDPLEZGRAIIjQVIEiJJQO xpWo3D9aFAOHRkyE2QNZgIfo2QhcQ8NeBk/gv71Y2nCR4d0G8Ei86cqS7XkAeSK7 ruAvjMkY5FiuneirP/NbDnkeX+yQtMfcCTTvgh6iKOduOJEqfpC/7Q7todyBwKxq fN1KPObScPOW9dACuQhGKZjo0C7zCbgaL3po1sLPcS8fRHZY8qFzyCm0PxDYfuM2 6Eff5Jfu6DXTT9PVxT5K0MJrgeQEuHXntLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678988855; x=1679075255; bh=ctE8I+bh+zObQorAgACu9RKFcOn0s7zBxu8 HFd+b51U=; b=DoVd1feB+OGKxt7IHZzl3SKqrrzcY/A6ndvP1/bZGSFRFxHFKu2 aHGD6CIofDbhbNnE8t+cQ8xXMbMCo81QxLxWdeObjTrUI0NiHzJm5SsHU13Bf7cc 14MF4qYooZNvM54vGJP46p5iUXfjIvpBrMgfLTi/gxm+C9X9wBQaaO+J13OR6i8P 4wLc+TrQ6kEgK+Lflmzf3h5QCn700hptzd8ZZ4feeZBKgqYkOKYfceltk+z9BaA2 fjm+/loQG+82ZaJzgJrbt/FkWPtPL4NwsySxC8djxyutgXpbVgEItWS6mtp+mLdD o1zL+lKEqJBPJHAywG4MVq/JTtEgReyVAuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 13:47:34 -0400 (EDT) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, pshukla@marvell.com Subject: Re: [PATCH v6 09/12] app/mldev: enable support for inference batches Date: Thu, 16 Mar 2023 18:47:33 +0100 Message-ID: <4252176.ejJDZkT8p0@thomas> In-Reply-To: <20230311150905.26824-10-syalavarthi@marvell.com> References: <20221129070746.20396-1-syalavarthi@marvell.com> <20230311150905.26824-1-syalavarthi@marvell.com> <20230311150905.26824-10-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/03/2023 16:09, Srikanth Yalavarthi: > @@ -528,8 +533,8 @@ ml_request_initialize(struct rte_mempool *mp, void *opaque, void *obj, unsigned > req->niters = 0; > > /* quantize data */ > - rte_ml_io_quantize(t->cmn.opt->dev_id, t->model[t->fid].id, > - t->model[t->fid].info.batch_size, t->model[t->fid].input, req->input); > + rte_ml_io_quantize(t->cmn.opt->dev_id, t->model[t->fid].id, t->model[t->fid].nb_batches, > + t->model[t->fid].input, req->input); > } > > int > @@ -547,7 +552,7 @@ ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t > int ret; > > /* get input buffer size */ > - ret = rte_ml_io_input_size_get(opt->dev_id, t->model[fid].id, t->model[fid].info.batch_size, > + ret = rte_ml_io_input_size_get(opt->dev_id, t->model[fid].id, t->model[fid].nb_batches, > &t->model[fid].inp_qsize, &t->model[fid].inp_dsize); > if (ret != 0) { > ml_err("Failed to get input size, model : %s\n", opt->filelist[fid].model); > @@ -555,9 +560,8 @@ ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t > } > > /* get output buffer size */ > - ret = rte_ml_io_output_size_get(opt->dev_id, t->model[fid].id, > - t->model[fid].info.batch_size, &t->model[fid].out_qsize, > - &t->model[fid].out_dsize); > + ret = rte_ml_io_output_size_get(opt->dev_id, t->model[fid].id, t->model[fid].nb_batches, > + &t->model[fid].out_qsize, &t->model[fid].out_dsize); > if (ret != 0) { > ml_err("Failed to get input size, model : %s\n", opt->filelist[fid].model); > return ret; > @@ -702,7 +706,7 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int > return; > > t->nb_used++; > - rte_ml_io_dequantize(t->cmn.opt->dev_id, model->id, t->model[req->fid].info.batch_size, > + rte_ml_io_dequantize(t->cmn.opt->dev_id, model->id, t->model[req->fid].nb_batches, > req->output, model->output); These changes look unrelated with the topic of the patch. You should probably fix it when adding those lines at first.